On 2019-08-20 02:52, Evgeny Mandrikov wrote:
Thank you for review and sponsoring!
Updated patch - http://cr.openjdk.java.net/~godin/8139820/webrev.01/
Ran it through the first couple of test tiers and pushed.
/Claes
On Mon, Aug 19, 2019 at 12:17 AM Claes Redestad
wrote:
> I'd add a comment that protocol is assumed to be "file",
URLClassPath.FileLoader class already has a comment "from a file URL that
refers to a directory",
but anyway added comment for constructor.
and perhaps make the constructor
> On 18 Aug 2019, at 23:18, Claes Redestad wrote:
>
> Hi,
>
> On 2019-08-18 21:22, Evgeny Mandrikov wrote:
>> [1] https://cr.openjdk.java.net/~godin/8139820/webrev.00/
>
> looks ok to me.
+1 seems ok to me.
-Chris
Hi,
On 2019-08-18 21:22, Evgeny Mandrikov wrote:
[1] https://cr.openjdk.java.net/~godin/8139820/webrev.00/
looks ok to me.
I'd add a comment that protocol is assumed to be "file", and perhaps
make the constructor private (valid since JDK 11).
I can sponsor the change, seeing how I
Hello!
Please review patch [1] for JDK-8139820 [2]. Also it needs a sponsor since
I have only author status in OpenJDK Census [3].
With best regards,
Evgeny Mandrikov
[1] https://cr.openjdk.java.net/~godin/8139820/webrev.00/
[2] https://bugs.openjdk.java.net/browse/JDK-8139820
[3]
