Re: RFR: JDK-8142936:Additional java.time.Duration methods

Hi , Thanks for the comments. Please see the updated webrev http://cr.openjdk.java.net/~ntv/8142936/webrev.04/ Thanks and Regards, Nadeesh On 12/4/2015 3:12 AM, Roger Riggs wrote: Hi Nadeesh, Thanks for the update, sorry I missed some editorial comments last time. toSeconds method missing a

Re: RFR: JDK-8142936:Additional java.time.Duration methods

Hi Nadeesh, Thanks for the update, sorry I missed some editorial comments last time. toSeconds method missing a final period '.' "* This returns the total number of seconds in the duration" toMinutesPart method: Extra text: + * @return the number of minutes parts in the duration, may be

Re: RFR: JDK-8142936:Additional java.time.Duration methods

Hi all, Please see the updated webrev - http://cr.openjdk.java.net/~ntv/8142936/webrev.03/ - changes - Modified the dataprovider as suggested by Roger Thanks and regards, Nadeesh On 12/1/2015 2:39 AM, Stephen Colebourne wrote: This is all about fixing a messy API that was created in

Re: RFR: JDK-8142936:Additional java.time.Duration methods

This is all about fixing a messy API that was created in 8. The methods propose are all about consistency. The toSeconds() method completes the set. For each unit there is a toXxx() and a toXxxPart(). Missing one out makes everything worse. Stephen On 30 November 2015 at 19:02, Roger Riggs

Re: RFR: JDK-8142936:Additional java.time.Duration methods

Hi Stephen, Nadeesh, The toXXXPart methods look fine. I'm not entirely convinced that the toSeconds() method is worth it and may be deemed as confusing with the new toSecondsPart method. How many people have problems with getSeconds()? The toXXXPart tests could have used a single

Re: RFR: JDK-8142936:Additional java.time.Duration methods

Hi all, Please see the updated webrev http://cr.openjdk.java.net/~ntv/8142936/webrev.02/ Regards, Nadeesh TV On 11/27/2015 11:20 PM, Stephen Colebourne wrote: "Overall, looks pretty good. There a a number of double spaces that should be single spaces in the Javadoc. Change "This is based on

Re: RFR: JDK-8142936:Additional java.time.Duration methods

"Overall, looks pretty good. There a a number of double spaces that should be single spaces in the Javadoc. Change "This is based on the standard definition of a day has 24 hours." to "This is based on the standard definition of a day as 24 hours." ("has" to "as") There are three places to fix

RFR: JDK-8142936:Additional java.time.Duration methods

Hi all, Please review a fix for Bug Id - https://bugs.openjdk.java.net/browse/JDK-8142936 -Enhance Duration by adding toNanosPart() , toMillisPart(),toSecondsPart(),toMinutesPart(),toHoursPart(),toDaysPart() methods . - Had to rename