Re: RFR: JDK-8145260: To bring j.u.z.ZipFile's native implementation to Java to remove the expensive jni cost and mmap crash risk [2]

On 12/14/15 1:13 AM, Seán Coffey wrote: Sherman, Changes look fine. One suggestion in ZipFile around line 956. Would you be better off managing the RandomAccessFile via try-with-resources. That would clean up your exception handling. Hi Sean, The "zfile" does not need to close if "new Rando

Re: RFR: JDK-8145260: To bring j.u.z.ZipFile's native implementation to Java to remove the expensive jni cost and mmap crash risk [2]

Ah - of course. That comment would been lack of coffee syndrome on my behalf earlier this morning then ;) Regards, Sean. On 14/12/15 16:36, Xueming Shen wrote: On 12/14/15 1:13 AM, Seán Coffey wrote: Sherman, Changes look fine. One suggestion in ZipFile around line 956. Would you be better

Re: RFR: JDK-8145260: To bring j.u.z.ZipFile's native implementation to Java to remove the expensive jni cost and mmap crash risk [2]

Sherman, Changes look fine. One suggestion in ZipFile around line 956. Would you be better off managing the RandomAccessFile via try-with-resources. That would clean up your exception handling. Regards, Sean. On 12/12/2015 18:43, Xueming Shen wrote: Hi, The changeset for JDK-8142508 had be

RFR: JDK-8145260: To bring j.u.z.ZipFile's native implementation to Java to remove the expensive jni cost and mmap crash risk [2]

Hi, The changeset for JDK-8142508 had been backout because it triggers jtreg fails in -avm mode with testng tests. Here is the updated version that fixes the problem. I'm using a different issue to trace this update change. issue: https://bugs.openjdk.java.net/browse/JDK-8145260 webrev: http: