RFR: JDK-8167648: java.io.PrintWriter should have PrintWriter((String|File), Charset) constructors

Any sponsor for this? > Am 23.11.2016 um 21:53 schrieb Patrick Reinhart : > > Hi Stephen, > > I changed the webrev accordingly: > > http://cr.openjdk.java.net/~reinhapa/reviews/8167648/webrev.00 > > -Patrick > >> Am 23.11.2016 um 14:45 schrieb Stephen Colebourne

Re: RFR: JDK-8167648: java.io.PrintWriter should have PrintWriter((String|File), Charset) constructors

Hi Stephen, I changed the webrev accordingly: http://cr.openjdk.java.net/~reinhapa/reviews/8167648/webrev.00 -Patrick > Am 23.11.2016 um 14:45 schrieb Stephen Colebourne : > > Returning the writer was my intention. I also intended it to return a > new instance, to avoid

Re: RFR: JDK-8167648: java.io.PrintWriter should have PrintWriter((String|File), Charset) constructors

Returning the writer was my intention. I also intended it to return a new instance, to avoid changing the variable from final to non-final. Stephen On 23 November 2016 at 13:35, Jonathan Bluett-Duncan wrote: > Hi Patrick, > > Have you considered making `withAutoFlush()`

Re: RFR: JDK-8167648: java.io.PrintWriter should have PrintWriter((String|File), Charset) constructors

On 2016-11-23 14:35, Jonathan Bluett-Duncan wrote: Hi Patrick, Have you considered making `withAutoFlush()` return the `PrintWriter` itself, allowing fluent code snippets like the following? ``` PrintWriter writer = new PrintWriter(new File("path/to/file.txt"),

Re: RFR: JDK-8167648: java.io.PrintWriter should have PrintWriter((String|File), Charset) constructors

Hi Patrick, Have you considered making `withAutoFlush()` return the `PrintWriter` itself, allowing fluent code snippets like the following? ``` PrintWriter writer = new PrintWriter(new File("path/to/file.txt"), StandardCharsets.UTF_8).withAutoFlush(); ``` Kind regards, Jonathan On 23 November

RFR: JDK-8167648: java.io.PrintWriter should have PrintWriter((String|File), Charset) constructors

Added those new public constructors: PrintWriter(OutputStream, Charset) PrintWriter(File, Charset) withAutoFlush() Also added a new private constructor: PrintWriter(OutputStream, Charset, boolean) and rewired the OutputStream constructor calls to this private constructor. Here's the

Re: RFR: JDK-8167648: java.io.PrintWriter should have PrintWriter((String|File), Charset) constructors

Hi Stephen, On 2016-11-23 12:04, Stephen Colebourne wrote: Perhaps a method withAutoFlush(boolean) could reduce the number of To make that work, we would have to make the boolean field "autoFlush" writeable. Also the auto flush behaviour could be changed at any time. I would then prefer

Re: RFR: JDK-8167648: java.io.PrintWriter should have PrintWriter((String|File), Charset) constructors

These are the current constructors: PrintWriter(Writer) PrintWriter(Writer, boolean) PrintWriter(OutputStream) PrintWriter(OutputStream, boolean) PrintWriter(String) PrintWriter(String, String) PrintWriter(File) PrintWriter(File, String) These are the annoying missing ones (not all of the

RFR: JDK-8167648: java.io.PrintWriter should have PrintWriter((String|File), Charset) constructors

Are there any obligations to add those constructors? -Patrick On 2016-11-18 10:19, Patrick Reinhart wrote: I was looking at the existing JDK 9 issues for some simple ones I could solve and found this one. I wanted to know if it makes sense to add additional constructors here? Now you need to