On Tue, 2 Feb 2021 21:00:00 GMT, Mahendra Chhipa
wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8183372
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Generate the source files in JTWork directory.
Looks good. Th
> https://bugs.openjdk.java.net/browse/JDK-8183372
Mahendra Chhipa has updated the pull request incrementally with one additional
commit since the last revision:
Generate the source files in JTWork directory.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2170/files
On Wed, 27 Jan 2021 23:03:55 GMT, Mahendra Chhipa
wrote:
>> test/jdk/java/lang/Class/getEnclosingClass/EnclosingClassTest.java line 126:
>>
>>> 124: Path pkg1Dir = Paths.get(SRC_DIR + "/pkg1");
>>> 125: FileUtils.deleteFileTreeWithRetry(pkg1Dir);
>>> 126: }
>>
>> I'm not co
> https://bugs.openjdk.java.net/browse/JDK-8183372
Mahendra Chhipa has updated the pull request incrementally with one additional
commit since the last revision:
Using testNg Assert instead of assert.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2170/files
- new: h
On Thu, 28 Jan 2021 00:34:08 GMT, Brent Christian wrote:
>> Mahendra Chhipa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Implemented the review comments.
>
> test/jdk/java/lang/Class/getEnclosingClass/EnclosingClassTest.java line 158:
On Mon, 1 Feb 2021 23:43:25 GMT, Brent Christian wrote:
>> Mahendra Chhipa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Implemented the review comments.
>
> Changes requested by bchristi (Reviewer).
(I think my comments may no have b
On Mon, 1 Feb 2021 22:23:02 GMT, Mahendra Chhipa
wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8183372
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
> throwing the specific exceptions.
test/jdk/java/lang/Class/get
On Wed, 27 Jan 2021 22:44:00 GMT, Mahendra Chhipa
wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8183372
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Implemented the review comments.
Changes requested by bchrist
On Mon, 1 Feb 2021 21:54:50 GMT, Mandy Chung wrote:
>> Mahendra Chhipa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Implemented the review comments.
>
> Marked as reviewed by mchung (Reviewer).
I think Brent wants to review it. I wi
> https://bugs.openjdk.java.net/browse/JDK-8183372
Mahendra Chhipa has updated the pull request incrementally with one additional
commit since the last revision:
throwing the specific exceptions.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2170/files
- new: https:
On Mon, 1 Feb 2021 21:46:00 GMT, Mahendra Chhipa
wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8183372
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Implemented the review comments.
Marked as reviewed by mchung
> https://bugs.openjdk.java.net/browse/JDK-8183372
Mahendra Chhipa has updated the pull request incrementally with one additional
commit since the last revision:
Implemented the review comments.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2170/files
- new: https:/
On Mon, 1 Feb 2021 20:27:00 GMT, Mahendra Chhipa
wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8183372
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Implemented the review comments.
Thanks for the update. This
> https://bugs.openjdk.java.net/browse/JDK-8183372
Mahendra Chhipa has updated the pull request incrementally with one additional
commit since the last revision:
Implemented the review comments.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2170/files
- new: https:/
> https://bugs.openjdk.java.net/browse/JDK-8183372
Mahendra Chhipa has updated the pull request incrementally with one additional
commit since the last revision:
Implemented the review comments.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2170/files
- new: https:/
> https://bugs.openjdk.java.net/browse/JDK-8183372
Mahendra Chhipa has updated the pull request incrementally with one additional
commit since the last revision:
Reset the formatting.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2170/files
- new: https://git.openjd
> https://bugs.openjdk.java.net/browse/JDK-8183372
Mahendra Chhipa has updated the pull request incrementally with one additional
commit since the last revision:
Implemented review comment.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2170/files
- new: https://git.
On Tue, 26 Jan 2021 22:55:32 GMT, Brent Christian wrote:
>> Mahendra Chhipa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Implemented the review comments.
>
> test/jdk/java/lang/Class/getEnclosingClass/EnclosingClassTest.java line 126:
> https://bugs.openjdk.java.net/browse/JDK-8183372
Mahendra Chhipa has updated the pull request incrementally with one additional
commit since the last revision:
Implemented the review comments.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2170/files
- new: https:/
On Tue, 26 Jan 2021 22:52:15 GMT, Brent Christian wrote:
>> Mahendra Chhipa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Implemented the review comments.
>
> test/jdk/java/lang/Class/getEnclosingClass/EnclosingClassTest.java line 76:
On Tue, 26 Jan 2021 23:25:03 GMT, Florent Guillaume
wrote:
>> Mahendra Chhipa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Implemented the review comments.
>
> test/jdk/java/lang/Class/forName/NonJavaNames.java line 67:
>
>> 65:
On Tue, 26 Jan 2021 22:56:25 GMT, Brent Christian wrote:
>> Mahendra Chhipa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Implemented the review comments.
>
> test/jdk/java/lang/Class/getEnclosingClass/EnclosingClassTest.java line 158:
On Mon, 25 Jan 2021 20:51:06 GMT, Mahendra Chhipa
wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8183372
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Implemented the review comments.
test/jdk/java/lang/Class/for
On Mon, 25 Jan 2021 20:51:06 GMT, Mahendra Chhipa
wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8183372
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Implemented the review comments.
I like keeping the changes w
On Tue, 26 Jan 2021 22:30:03 GMT, Mandy Chung wrote:
>> To avoid the Checkstyle warnings, I added them.
>
> Is it from your IDE configurations? You can turn off Checkstyle warnings.
> This just adds noise.
I also assume some of the formatting changes are changed by your IDE
suggestion. Can
On Mon, 25 Jan 2021 19:33:08 GMT, Mahendra Chhipa
wrote:
>> test/jdk/java/lang/Class/getEnclosingClass/EnclosingClassTest.java line 103:
>>
>>> 101: createAndWriteEnclosingClasses(enclosingPath, pkg2File,
>>> "pkg1.pkg2");
>>> 102:
>>> 103: String javacPath = JDKToolFinder.get
On Mon, 25 Jan 2021 20:51:06 GMT, Mahendra Chhipa
wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8183372
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Implemented the review comments.
test/jdk/java/lang/Class/for
> https://bugs.openjdk.java.net/browse/JDK-8183372
Mahendra Chhipa has updated the pull request incrementally with one additional
commit since the last revision:
Implemented the review comments.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2170/files
- new: https:/
On Fri, 22 Jan 2021 18:17:33 GMT, Mandy Chung wrote:
>> Mahendra Chhipa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> NonJavaName Tests updated
>> Used newInstance() method to create the different EnclosingClasses at
>> runtime
>
>
On Fri, 22 Jan 2021 18:09:43 GMT, Mandy Chung wrote:
>> Mahendra Chhipa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> NonJavaName Tests updated
>> Used newInstance() method to create the different EnclosingClasses at
>> runtime
>
>
On Fri, 22 Jan 2021 18:16:54 GMT, Mandy Chung wrote:
>> Mahendra Chhipa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> NonJavaName Tests updated
>> Used newInstance() method to create the different EnclosingClasses at
>> runtime
>
>
On Fri, 22 Jan 2021 17:59:33 GMT, Mandy Chung wrote:
>> Mahendra Chhipa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> NonJavaName Tests updated
>> Used newInstance() method to create the different EnclosingClasses at
>> runtime
>
>
On Fri, 22 Jan 2021 16:57:41 GMT, Mahendra Chhipa
wrote:
>> Can this be done all in `EnclosingClassTest.java`, without a new
>> `RunEnclosingClassTest.java`?
>>
>> Adding the `@BeforeClass` and `@AfterClass` methods to what's there, you may
>> just need to
>> change the `test()` calls to use
On Fri, 22 Jan 2021 16:52:02 GMT, Mahendra Chhipa
wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8183372
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
> NonJavaName Tests updated
> Used newInstance() method to cre
On Thu, 21 Jan 2021 05:19:00 GMT, Brent Christian wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8183372
>
> Can this be done all in `EnclosingClassTest.java`, without a new
> `RunEnclosingClassTest.java`?
>
> Adding the `@BeforeClass` and `@AfterClass` methods to what's there, you may
> j
> https://bugs.openjdk.java.net/browse/JDK-8183372
Mahendra Chhipa has updated the pull request incrementally with one additional
commit since the last revision:
NonJavaName Tests updated
Used newInstance() method to create the different EnclosingClasses at runtime
-
Changes:
On Wed, 20 Jan 2021 17:27:43 GMT, Mahendra Chhipa
wrote:
> https://bugs.openjdk.java.net/browse/JDK-8183372
Can this be done all in `EnclosingClassTest.java`, without a new
`RunEnclosingClassTest.java`?
Adding the `@BeforeClass` and `@AfterClass` methods to what's there, you may
just need to
https://bugs.openjdk.java.net/browse/JDK-8183372
-
Commit messages:
- JDK-8183372 : Refactor java/lang/Class shell tests to java
Changes: https://git.openjdk.java.net/jdk/pull/2170/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2170&range=00
Issue: https://bugs.openj
38 matches
Mail list logo
