Re: RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v3]

2021-02-02 Thread Brent Christian
On Wed, 27 Jan 2021 23:03:55 GMT, Mahendra Chhipa wrote: >> test/jdk/java/lang/Class/getEnclosingClass/EnclosingClassTest.java line 126: >> >>> 124: Path pkg1Dir = Paths.get(SRC_DIR + "/pkg1"); >>> 125: FileUtils.deleteFileTreeWithRetry(pkg1Dir); >>> 126: } >> >> I'm not co

Re: RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v3]

2021-01-27 Thread Mahendra Chhipa
On Tue, 26 Jan 2021 22:55:32 GMT, Brent Christian wrote: >> Mahendra Chhipa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Implemented the review comments. > > test/jdk/java/lang/Class/getEnclosingClass/EnclosingClassTest.java line 126:

Re: RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v3]

2021-01-27 Thread Mahendra Chhipa
On Tue, 26 Jan 2021 22:52:15 GMT, Brent Christian wrote: >> Mahendra Chhipa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Implemented the review comments. > > test/jdk/java/lang/Class/getEnclosingClass/EnclosingClassTest.java line 76:

Re: RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v3]

2021-01-27 Thread Mahendra Chhipa
On Tue, 26 Jan 2021 23:25:03 GMT, Florent Guillaume wrote: >> Mahendra Chhipa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Implemented the review comments. > > test/jdk/java/lang/Class/forName/NonJavaNames.java line 67: > >> 65:

Re: RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v3]

2021-01-27 Thread Mahendra Chhipa
On Tue, 26 Jan 2021 22:56:25 GMT, Brent Christian wrote: >> Mahendra Chhipa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Implemented the review comments. > > test/jdk/java/lang/Class/getEnclosingClass/EnclosingClassTest.java line 158:

Re: RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v3]

2021-01-26 Thread Florent Guillaume
On Mon, 25 Jan 2021 20:51:06 GMT, Mahendra Chhipa wrote: >> https://bugs.openjdk.java.net/browse/JDK-8183372 > > Mahendra Chhipa has updated the pull request incrementally with one > additional commit since the last revision: > > Implemented the review comments. test/jdk/java/lang/Class/for

Re: RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v3]

2021-01-26 Thread Brent Christian
On Mon, 25 Jan 2021 20:51:06 GMT, Mahendra Chhipa wrote: >> https://bugs.openjdk.java.net/browse/JDK-8183372 > > Mahendra Chhipa has updated the pull request incrementally with one > additional commit since the last revision: > > Implemented the review comments. I like keeping the changes w

Re: RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v3]

2021-01-26 Thread Mandy Chung
On Mon, 25 Jan 2021 20:51:06 GMT, Mahendra Chhipa wrote: >> https://bugs.openjdk.java.net/browse/JDK-8183372 > > Mahendra Chhipa has updated the pull request incrementally with one > additional commit since the last revision: > > Implemented the review comments. test/jdk/java/lang/Class/for

Re: RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v3]

2021-01-25 Thread Mahendra Chhipa
> https://bugs.openjdk.java.net/browse/JDK-8183372 Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Implemented the review comments. - Changes: - all: https://git.openjdk.java.net/jdk/pull/2170/files - new: https:/