Re: RFR: JDK-8183579: refactor and cleanup launcher help messages

2017-07-28 Thread Kumar Srinivasan
Mandy, Thanks for the reviewplease see in-lined comments, On Jul 20, 2017, at 11:53 AM, Kumar Srinivasan wrote: Hi, Please review refactoring and clean up of the java launcher's help/usage messages. The highlights of the changes are as follows: 1. Helper.java: is renamed from Launcher

Re: RFR: JDK-8183579: refactor and cleanup launcher help messages

2017-07-26 Thread Mandy Chung
> On Jul 20, 2017, at 11:53 AM, Kumar Srinivasan > wrote: > > Hi, > > Please review refactoring and clean up of the java launcher's help/usage > messages. > > The highlights of the changes are as follows: > > 1. Helper.java: is renamed from LauncherHelper.java, simpler name, >containing

RFR: JDK-8183579: refactor and cleanup launcher help messages

2017-07-20 Thread Kumar Srinivasan
Hi, Please review refactoring and clean up of the java launcher's help/usage messages. The highlights of the changes are as follows: 1. Helper.java: is renamed from LauncherHelper.java, simpler name, containing mostly methods to help with class loading, module assistance etc. 2. OptionHe