Re: RFR: JDK-8190417 java.util.regex.Matcher method doc points to incorrect links

HI Michal, David, Thank you both. I am doing a build, will sanity check the changes via the generated javadoc Best Lance > On May 31, 2018, at 8:00 AM, Michal Vala wrote: > > Hi Lance, > > here's current webrev: > http://cr.openjdk.java.net/~mvala/jdk/jdk/JDK-8190417/webrev.01/ >

Re: RFR: JDK-8190417 java.util.regex.Matcher method doc points to incorrect links

Hi Lance, here's current webrev: http://cr.openjdk.java.net/~mvala/jdk/jdk/JDK-8190417/webrev.01/ On 05/31/2018 12:45 PM, Lance Andersen wrote: Hi Michal, Any additional changes we can use this bug. If you have made additional changes, please point me to your latest update when you think yo

Re: RFR: JDK-8190417 java.util.regex.Matcher method doc points to incorrect links

Hi Michal, Any additional changes we can use this bug. If you have made additional changes, please point me to your latest update when you think you have made your last set of tweaks. Best Lance > On May 31, 2018, at 6:09 AM, Michal Vala wrote: > > Hi Lance, David, > > I've found few more ja

Re: RFR: JDK-8190417 java.util.regex.Matcher method doc points to incorrect links

Hi Lance, David, I've found few more javadoc line length issues, so I've fixed that. Regarding to linking methods, I guess all links should have arguments. Now when I link `#appendTail`, it goes to first instance, which is appendTail(StringBuffer). So it should be explicit everywhere, Right? S

Re: RFR: JDK-8190417 java.util.regex.Matcher method doc points to incorrect links

Hi Lance, Michal, When I looked into javadoc rules last week it seemed that links to methods should include the () if no-args ie. + * {@link #find find} methods. should be + * {@link #find() find} methods. Of course now I can't find those rules! The javadoc guide [1] doesn't seem t

Re: RFR: JDK-8190417 java.util.regex.Matcher method doc points to incorrect links

Hi Michal, I made a couple of additional minor tweaks - Cleaned the line length in a couple of places - Addressed an inconsistency where Matcher’s was used in place of matcher’s (which is used everywhere else in the javadoc) Here is the updated diff: —— $ hg diff src/java.base/share/c

Re: RFR: JDK-8190417 java.util.regex.Matcher method doc points to incorrect links

Hi Lance, thanks, I'd appreciate that On 05/30/2018 04:32 PM, Lance Andersen wrote: I can sponsor this for you On May 30, 2018, at 7:17 AM, Michal Vala wrote: Hi, please review and eventually sponsor this small doc patch fixing method links in java.util.regex.Matcher webrev: http://cr.op

Re: RFR: JDK-8190417 java.util.regex.Matcher method doc points to incorrect links

I can sponsor this for you > On May 30, 2018, at 7:17 AM, Michal Vala wrote: > > Hi, > > please review and eventually sponsor this small doc patch fixing method links > in java.util.regex.Matcher > > webrev: http://cr.openjdk.java.net/~mvala/jdk/jdk/JDK-8190417/webrev.00/ > > Thanks! > > --

RFR: JDK-8190417 java.util.regex.Matcher method doc points to incorrect links

Hi, please review and eventually sponsor this small doc patch fixing method links in java.util.regex.Matcher webrev: http://cr.openjdk.java.net/~mvala/jdk/jdk/JDK-8190417/webrev.00/ Thanks! -- Michal Vala OpenJDK QE Red Hat Czech