Re: RFR: JDK-8209774 - [TESTBUG]Refactor shell test javax/xml/jaxp/common/8035437/run.sh to java

+1 Joe On 5/14/2020 2:14 AM, Daniel Fuchs wrote: Hi Fernando, That looks good to me. best regards, -- daniel On 12/05/2020 11:46, Fernando Guallini wrote: Thanks for your comments. Below you can find a new web rev version that includes a test description in a comment: http://cr.openjdk.ja

Re: RFR: JDK-8209774 - [TESTBUG]Refactor shell test javax/xml/jaxp/common/8035437/run.sh to java

Hi Fernando, That looks good to me. best regards, -- daniel On 12/05/2020 11:46, Fernando Guallini wrote: Thanks for your comments. Below you can find a new web rev version that includes a test description in a comment: http://cr.openjdk.java.net/~fyuan/fernando/8209774/webrev.01/

Re: RFR: JDK-8209774 - [TESTBUG]Refactor shell test javax/xml/jaxp/common/8035437/run.sh to java

Thanks for your comments. Below you can find a new web rev version that includes a test description in a comment: http://cr.openjdk.java.net/~fyuan/fernando/8209774/webrev.01/ I will also create a JBS ticket to revisit this test and

Re: RFR: JDK-8209774 - [TESTBUG]Refactor shell test javax/xml/jaxp/common/8035437/run.sh to java

On 5/11/2020 2:32 AM, Alan Bateman wrote: On 08/05/2020 18:19, Fernando Guallini wrote: Hi Daniel and Alan, @compile/module=java.xml was my first try, but for the nature of this test, it didn't work. The reason is that the original shell test does the following: - Compiles it’s own version

Re: RFR: JDK-8209774 - [TESTBUG]Refactor shell test javax/xml/jaxp/common/8035437/run.sh to java

On 08/05/2020 18:19, Fernando Guallini wrote: Hi Daniel and Alan, @compile/module=java.xml was my first try, but for the nature of this test, it didn't work. The reason is that the original shell test does the following: - Compiles it’s own version of Node and Document interfaces - Compiles Do

Re: RFR: JDK-8209774 - [TESTBUG]Refactor shell test javax/xml/jaxp/common/8035437/run.sh to java

Hi Fernando, While you add the comment (about compile/run), you may want to update the original comment about the test as well as it mentioned "see run.sh" that is now gone. A minor comment on the header:  a space between the years would be good, that is "2014,2020," -> 2014, 2020, -Joe O

Re: RFR: JDK-8209774 - [TESTBUG]Refactor shell test javax/xml/jaxp/common/8035437/run.sh to java

Sure, I will add some of the explanation as a comment. Thank you Daniel! > On 8 May 2020, at 18:39, Daniel Fuchs wrote: > > Hi Fernando, > > Ah - I see the keypoint is the: > 39 * @clean org.w3c.dom.* > OK, I missed that. Then I agree - ignore my previous comments. > > Maybe the explanations

Re: RFR: JDK-8209774 - [TESTBUG]Refactor shell test javax/xml/jaxp/common/8035437/run.sh to java

Hi Fernando, Ah - I see the keypoint is the: 39 * @clean org.w3c.dom.* OK, I missed that. Then I agree - ignore my previous comments. Maybe the explanations below should be added to the test in some comment to help future maintainers (and reviewers). best regards, -- daniel On 08/05/2020

Re: RFR: JDK-8209774 - [TESTBUG]Refactor shell test javax/xml/jaxp/common/8035437/run.sh to java

Hi Daniel and Alan, @compile/module=java.xml was my first try, but for the nature of this test, it didn't work. The reason is that the original shell test does the following: - Compiles it’s own version of Node and Document interfaces - Compiles DocumentImpl patching java.xml with those 2 interf

Re: RFR: JDK-8209774 - [TESTBUG]Refactor shell test javax/xml/jaxp/common/8035437/run.sh to java

On 08/05/2020 15:40, Alan Bateman wrote:   31 /*   32  * @test   33  * @bug 8035437   34  * @summary Tests that java.lang.AbstractMethodError is not thrown when   35  * serializing improper version of DocumentImpl class.   36  * @library /test/lib   * @modules javax.xml/org.w3c.dom   * 

Re: RFR: JDK-8209774 - [TESTBUG]Refactor shell test javax/xml/jaxp/common/8035437/run.sh to java

On 08/05/2020 15:16, Daniel Fuchs wrote: : then:   31 /*   32  * @test   33  * @bug 8035437   34  * @summary Tests that java.lang.AbstractMethodError is not thrown when   35  * serializing improper version of DocumentImpl class.   36  * @library /test/lib   * @modules javax.xml/org.w3c.do

Re: RFR: JDK-8209774 - [TESTBUG]Refactor shell test javax/xml/jaxp/common/8035437/run.sh to java

Hi Fernando, I believe that if you simply move the patched file under a directory named javax.xml, then you can get rid of all the @compile in the test. Starting from your patch: cd test/jdk/javax/xml/jaxp/common/8035437 mkdir java.xml hg move org javax.xml hg move com javax.xml then: 31 /*

RFR: JDK-8209774 - [TESTBUG]Refactor shell test javax/xml/jaxp/common/8035437/run.sh to java

Hi all, Please, review the following change: webrev: http://cr.openjdk.java.net/~fyuan/fernando/8209774/webrev.00/ Testbug: https://bugs.openjdk.java.net/browse/JDK-8209774 Change