looks good.
/Andy
On 3/7/2019 5:52 PM, Alexander Matveev wrote:
Hi Erik,
http://cr.openjdk.java.net/~almatvee/8214566/webrev.01/
- Removed $(call SET_SHARED_LIBRARY_ORIGIN), TOOLCHAIN_LINK_CXX and
linking with libjava.
Thanks,
Alexander
On 3/7/2019 6:52 AM, Erik Joelsson wrote:
Hello
Build changes look good.
/Erik
On 2019-03-07 14:52, Alexander Matveev wrote:
Hi Erik,
http://cr.openjdk.java.net/~almatvee/8214566/webrev.01/
- Removed $(call SET_SHARED_LIBRARY_ORIGIN), TOOLCHAIN_LINK_CXX and
linking with libjava.
Thanks,
Alexander
On 3/7/2019 6:52 AM, Erik Joelsson
Hi Erik,
http://cr.openjdk.java.net/~almatvee/8214566/webrev.01/
- Removed $(call SET_SHARED_LIBRARY_ORIGIN), TOOLCHAIN_LINK_CXX and
linking with libjava.
Thanks,
Alexander
On 3/7/2019 6:52 AM, Erik Joelsson wrote:
Hello Alexander,
A few notes:
$(call SET_SHARED_LIBRARY_ORIGIN) and
Hello Alexander,
A few notes:
$(call SET_SHARED_LIBRARY_ORIGIN) and TOOLCHAIN_LINK_CXX have no effect
on Windows, so should be removed to avoid confusion in the future.
This new library does not link with libjava so I see no need to add that
prerequisite declaration.
/Erik
On 2019-03-06
Looks good to me:
You may want to get approval from build team for makefile changes.
/Andy
On 3/6/2019 8:10 PM, Alexander Matveev wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Added
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Added custom action to check installation folder and display
confirmation dialog to ask user to continue installation if destination
folder is not
