Re: RFR: JDK-8215648: remove equals and hashCode implementations from j.l.i.VarHandle

2018-12-19 Thread Mandy Chung
Looks fine to me. Mandy On 12/19/18 1:27 PM, Vicente Romero wrote: Please review fix for [1] at [2]. The fx is basically removing the implementation of methods VarHandle::equals and VarHandle::hashCode to make var handles consistent with method handles which don't override the default

Re: RFR: JDK-8215648: remove equals and hashCode implementations from j.l.i.VarHandle

2018-12-19 Thread Vicente Romero
Please review also the related CSR: https://bugs.openjdk.java.net/browse/JDK-8215649 Thanks, Vicente On 12/19/18 4:27 PM, Vicente Romero wrote: Please review fix for [1] at [2]. The fx is basically removing the implementation of methods VarHandle::equals and VarHandle::hashCode to make var

RFR: JDK-8215648: remove equals and hashCode implementations from j.l.i.VarHandle

2018-12-19 Thread Vicente Romero
Please review fix for [1] at [2]. The fx is basically removing the implementation of methods VarHandle::equals and VarHandle::hashCode to make var handles consistent with method handles which don't override the default implementation for these methods, Thanks, Vicente [1]