Hi Andy,
Revised webrev looks good.
Thanks,
Alexander
On 2/27/2019 4:41 PM, Andy Herrick wrote:
revised webrev at http://cr.openjdk.java.net/~herrick/8217902/webrev.02/
Do not Log a verbose message when cfg not found in getAppName() - just
use APP_NAME parameter as is done on Linux and Mac
revised webrev at http://cr.openjdk.java.net/~herrick/8217902/webrev.02/
Do not Log a verbose message when cfg not found in getAppName() - just
use APP_NAME parameter as is done on Linux and Mac
/Andy
On 2/26/2019 8:15 AM, Andy Herrick wrote:
JDK-8217902: jpackage fails with --app-image
Hi Andy,
http://cr.openjdk.java.net/~herrick/8217902/webrev.01/src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WinAppBundler.java.frames.html
Line 135 - Did you mean to put error message in else statement before
throwing exception?
Otherwise looks fine.
Thanks,
Alexander
On 2/26/2019
JDK-8217902: jpackage fails with --app-image option on mac
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
The fix is to remove the over-aggressive validation in
DeployParams.validate() and update
