Re: RFR: JDK-8219480: j.l.c.ClassDesc::arrayType(int rank) throws IllegalArgumentException if rank = 0

thanks :) Vicente On 2/22/19 2:50 PM, Mandy Chung wrote: On 2/22/19 8:37 AM, Vicente Romero wrote: Hi Mandy, Thanks for the review. I have uploaded a new iteration [1], please also review the CSR at [2] Vicente [1] http://cr.openjdk.java.net/~vromero/8219480/webrev.01/ Looks good.

Re: RFR: JDK-8219480: j.l.c.ClassDesc::arrayType(int rank) throws IllegalArgumentException if rank = 0

On 2/22/19 8:37 AM, Vicente Romero wrote: Hi Mandy, Thanks for the review. I have uploaded a new iteration [1], please also review the CSR at [2] Vicente [1] http://cr.openjdk.java.net/~vromero/8219480/webrev.01/ Looks good. [2] https://bugs.openjdk.java.net/browse/JDK-8219587

Re: RFR: JDK-8219480: j.l.c.ClassDesc::arrayType(int rank) throws IllegalArgumentException if rank = 0

Hi Mandy, Thanks for the review. I have uploaded a new iteration [1], please also review the CSR at [2] Vicente [1] http://cr.openjdk.java.net/~vromero/8219480/webrev.01/ [2] https://bugs.openjdk.java.net/browse/JDK-8219587 On 2/21/19 5:22 PM, Mandy Chung wrote: On 2/20/19 3:10 PM,

Re: RFR: JDK-8219480: j.l.c.ClassDesc::arrayType(int rank) throws IllegalArgumentException if rank = 0

On 2/20/19 3:10 PM, Vicente Romero wrote: Please review the simple patch to fix [1] at [2]. The patch is simply adding a comment to the API, (javadoc) to sync it with the implementation. Thanks, Vicente [1] https://bugs.openjdk.java.net/browse/JDK-8219480 [2]

RFR: JDK-8219480: j.l.c.ClassDesc::arrayType(int rank) throws IllegalArgumentException if rank = 0

Please review the simple patch to fix [1] at [2]. The patch is simply adding a comment to the API, (javadoc) to sync it with the implementation. Thanks, Vicente [1] https://bugs.openjdk.java.net/browse/JDK-8219480 [2] http://cr.openjdk.java.net/~vromero/8219480/webrev.00/