yes - I was thinking the list of extension need not be localized but
didn't think of the "and" in it - will think of another way to do this.
/Andy
On 3/4/2019 6:56 PM, Jonathan Gibbons wrote:
Andy,
Is it something to be concerned about that you have English text
directly in the source code,
Andy,
Is it something to be concerned about that you have English text
directly in the source code, at CLIHelp.java, lines 57-65. Specifically,
the repeated use of "and".
Is that something that should be localizable?
-- Jon
On 3/3/19 7:34 AM, Andy Herrick wrote:
Please review the jpackage
Hi Andy,
http://cr.openjdk.java.net/~herrick/8219679/webrev.02/src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources.properties.frames.html
Line 109: Missing ">" after main class?
Line 132: additionl - > additional
Otherwise looks fine.
Thanks,
Alexander
On 3/3/2019 7:34
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
[1] https://bugs.openjdk.java.net/browse/JDK-8219679
[2] http://cr.openjdk.java.net/~herrick/8219679/
/Andy
