Re: RFR: JDK-8221642: AccessibleObject::setAccessible throws NPE when invoked by JNI code with no java frame on stack

2022-01-31 Thread Mandy Chung
On Fri, 28 Jan 2022 17:50:19 GMT, Mandy Chung wrote: > `AccessibleObject::setAccessible` and `trySetAccessible` methods should only > allow access to public member of a public type that is unconditionally > exported consistent with the access check as described in the class > specification,

Re: RFR: JDK-8221642: AccessibleObject::setAccessible throws NPE when invoked by JNI code with no java frame on stack [v2]

2022-01-31 Thread Mandy Chung
On Sun, 30 Jan 2022 21:59:19 GMT, David Holmes wrote: >> Mandy Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix typo > > src/java.base/share/classes/java/lang/reflect/AccessibleObject.java line 260: > >> 258: * If this

Re: RFR: JDK-8221642: AccessibleObject::setAccessible throws NPE when invoked by JNI code with no java frame on stack [v2]

2022-01-31 Thread Mandy Chung
> `AccessibleObject::setAccessible` and `trySetAccessible` methods should only > allow access to public member of a public type that is unconditionally > exported consistent with the access check as described in the class > specification, when invoked by JNI code with no Java class on the

Re: RFR: JDK-8221642: AccessibleObject::setAccessible throws NPE when invoked by JNI code with no java frame on stack

2022-01-30 Thread David Holmes
On Fri, 28 Jan 2022 17:50:19 GMT, Mandy Chung wrote: > `AccessibleObject::setAccessible` and `trySetAccessible` methods should only > allow access to public member of a public type that is unconditionally > exported consistent with the access check as described in the class > specification,

Re: RFR: JDK-8221642: AccessibleObject::setAccessible throws NPE when invoked by JNI code with no java frame on stack

2022-01-30 Thread Alan Bateman
On Sun, 30 Jan 2022 22:06:20 GMT, David Holmes wrote: > There is no spec change here as you note, but the behavioural change also > makes this warrant a CSR request IMO. It's in draft: https://bugs.openjdk.java.net/browse/JDK-8280831, I assume Mandy will finalize shortly. - PR:

Re: RFR: JDK-8221642: AccessibleObject::setAccessible throws NPE when invoked by JNI code with no java frame on stack

2022-01-30 Thread David Holmes
On Fri, 28 Jan 2022 17:50:19 GMT, Mandy Chung wrote: > `AccessibleObject::setAccessible` and `trySetAccessible` methods should only > allow access to public member of a public type that is unconditionally > exported consistent with the access check as described in the class > specification,

Re: RFR: JDK-8221642: AccessibleObject::setAccessible throws NPE when invoked by JNI code with no java frame on stack

2022-01-30 Thread David Holmes
On Fri, 28 Jan 2022 17:50:19 GMT, Mandy Chung wrote: > `AccessibleObject::setAccessible` and `trySetAccessible` methods should only > allow access to public member of a public type that is unconditionally > exported consistent with the access check as described in the class > specification,

Re: RFR: JDK-8221642: AccessibleObject::setAccessible throws NPE when invoked by JNI code with no java frame on stack

2022-01-30 Thread Alan Bateman
On Fri, 28 Jan 2022 17:50:19 GMT, Mandy Chung wrote: > `AccessibleObject::setAccessible` and `trySetAccessible` methods should only > allow access to public member of a public type that is unconditionally > exported consistent with the access check as described in the class > specification,

RFR: JDK-8221642: AccessibleObject::setAccessible throws NPE when invoked by JNI code with no java frame on stack

2022-01-28 Thread Mandy Chung
`AccessibleObject::setAccessible` and `trySetAccessible` methods should only allow access to public member of a public type that is unconditionally exported consistent with the access check as described in the class specification, when invoked by JNI code with no Java class on the stack. The