Re: RFR: JDK-8223322: Improve concurrency in jpackage instances [v2]

2021-01-04 Thread Andy Herrick
> Remove all non final static variables in jpackage java code (using > InheritableThreadLocal for Logger and Argument instances) and remove > sychronization in JPackageToolProvider. Andy Herrick has updated the pull request incrementally with one additional commit since the last revision: JD

Re: RFR: JDK-8223322: Improve concurrency in jpackage instances

2020-12-18 Thread Alexey Semenyuk
On Fri, 18 Dec 2020 14:59:06 GMT, Andy Herrick wrote: > I have had problems with test infrastructure fixing the workDir based on test > class and method, and then getting IOExceptions as various PackageTest's try > to write the same content to the same work dir I don't think we need changes to

Re: RFR: JDK-8223322: Improve concurrency in jpackage instances

2020-12-18 Thread Andy Herrick
On Fri, 18 Dec 2020 15:00:13 GMT, Andy Herrick wrote: >>> >>> >>> I'd propose to update the test to run more that two concurrent instance of >>> jpackage command. >> >> yes - I'm planning for a lot more in next revision, your suggestion to use >> only PackageTest.Action.CREATE will go a long

Re: RFR: JDK-8223322: Improve concurrency in jpackage instances

2020-12-18 Thread Andy Herrick
On Fri, 18 Dec 2020 14:59:06 GMT, Andy Herrick wrote: >> I'd propose to update the test to run more that two concurrent instance of >> jpackage command. > >> >> >> I'd propose to update the test to run more that two concurrent instance of >> jpackage command. > > yes - I'm planning for a lot

Re: RFR: JDK-8223322: Improve concurrency in jpackage instances

2020-12-18 Thread Andy Herrick
On Thu, 17 Dec 2020 23:26:44 GMT, Alexey Semenyuk wrote: > > > I'd propose to update the test to run more that two concurrent instance of > jpackage command. yes - I'm planning for a lot more in next revision, your suggestion to use only PackageTest.Action.CREATE will go a long way to making

Re: RFR: JDK-8223322: Improve concurrency in jpackage instances

2020-12-18 Thread Andy Herrick
On Thu, 17 Dec 2020 23:26:44 GMT, Alexey Semenyuk wrote: >> Changes requested by asemenyuk (Committer). > > I'd propose to update the test to run more that two concurrent instance of > jpackage command. > > > Changes looks fine, but are we sure that external 3rd party tools used by > jpackag

Re: RFR: JDK-8223322: Improve concurrency in jpackage instances

2020-12-17 Thread Alexey Semenyuk
On Thu, 17 Dec 2020 23:24:02 GMT, Alexey Semenyuk wrote: >> Remove all non final static variables in jpackage java code (using >> InheritableThreadLocal for Logger and Argument instances) and remove >> sychronization in JPackageToolProvider. > > Changes requested by asemenyuk (Committer). I'd

Re: RFR: JDK-8223322: Improve concurrency in jpackage instances

2020-12-17 Thread Alexey Semenyuk
On Thu, 17 Dec 2020 20:46:50 GMT, Andy Herrick wrote: > Remove all non final static variables in jpackage java code (using > InheritableThreadLocal for Logger and Argument instances) and remove > sychronization in JPackageToolProvider. test/jdk/tools/jpackage/share/ConcurrentTest.java line 68:

Re: RFR: JDK-8223322: Improve concurrency in jpackage instances

2020-12-17 Thread Alexey Semenyuk
On Thu, 17 Dec 2020 20:46:50 GMT, Andy Herrick wrote: > Remove all non final static variables in jpackage java code (using > InheritableThreadLocal for Logger and Argument instances) and remove > sychronization in JPackageToolProvider. Changes requested by asemenyuk (Committer). test/jdk/tool

Re: RFR: JDK-8223322: Improve concurrency in jpackage instances

2020-12-17 Thread Alexander Matveev
On Thu, 17 Dec 2020 20:46:50 GMT, Andy Herrick wrote: > Remove all non final static variables in jpackage java code (using > InheritableThreadLocal for Logger and Argument instances) and remove > sychronization in JPackageToolProvider. Changes looks fine, but are we sure that external 3rd part

RFR: JDK-8223322: Improve concurrency in jpackage instances

2020-12-17 Thread Andy Herrick
Remove all non final static variables in jpackage java code (using InheritableThreadLocal for Logger and Argument instances) and remove sychronization in JPackageToolProvider. - Commit messages: - JDK-8223322: Improve concurrency in jpackage instances - JDK-8223322: Improve concur