Re: RFR: JDK-8224158: assertion related to NPE at DynamicCallSiteDesc::withArgs should be reworded

2019-05-29 Thread Roger Riggs
Hi Vicente, Why fix just this one method? The other methods of DynamicCallSiteDesc do not make the same claim for bootstrapArgs and the code does not check for the contents being null nor does the constructor that is invoked that clones the array. (Line 81). The overhead of a change and CSR i

RFR: JDK-8224158: assertion related to NPE at DynamicCallSiteDesc::withArgs should be reworded

2019-05-29 Thread Vicente Romero
Please review fix for [1] at [2] and the CSR at [3]. This is a simple fix that is just rewording an assertion at method java.lang.constant.DynamicCallSiteDesc::withArgs. The fix is simply: diff -r dd321e3596c0 -r 78f3b29fb255 src/java.base/share/classes/java/lang/constant/DynamicCallSiteDesc.j