Looks good.
On 6/14/2019 8:54 AM, Andy Herrick wrote:
On 6/14/2019 11:44 AM, Kevin Rushforth wrote:
Looks good.
Btw, there is a trailing whitespace you might want to fix (although
that can be done later as a bulk update if you prefer).
On 6/14/2019 11:44 AM, Kevin Rushforth wrote:
Looks good.
Btw, there is a trailing whitespace you might want to fix (although
that can be done later as a bulk update if you prefer).
test/jdk/tools/jpackage/createappimage/JPackageCreateAppImageBase.java:50:
Trailing whitespace
will fix
Looks good.
Btw, there is a trailing whitespace you might want to fix (although that
can be done later as a bulk update if you prefer).
test/jdk/tools/jpackage/createappimage/JPackageCreateAppImageBase.java:50:
Trailing whitespace
-- Kevin
On 6/14/2019 7:17 AM, Andy Herrick wrote:
Looks good.
- Alexey
On 6/14/2019 10:17 AM, Andy Herrick wrote:
Please review the revised jpackage fix [3] for issue [1]
revised to use Path.of() in JPackagePath test helper and to centralize
code that creates output dirs and/or makes sure they are empty and
writable.
[3]
Please review the revised jpackage fix [3] for issue [1]
revised to use Path.of() in JPackagePath test helper and to centralize
code that creates output dirs and/or makes sure they are empty and writable.
[3] http://cr.openjdk.java.net/~herrick/8225569/webrev.02/
/Andy
On 6/13/2019 1:21
On 6/13/2019 5:34 PM, Alexander Matveev wrote:
Hi Andy,
1) I think it is better to move mksure() to common place like IOUtils,
otherwise it is duplicated in WindowsAppImageBuilder.java and
LinuxAppImageBuilder.java.
yes - this same pattern is repeated in nearly a dozen other places, and
Hi Andy,
1) I think it is better to move mksure() to common place like IOUtils,
otherwise it is duplicated in WindowsAppImageBuilder.java and
LinuxAppImageBuilder.java.
2) For Alexey comment I think it is good idea to use Paths.get(), but I
think it should be done as separate cleanup bug.
Please note that it is recommended to use Path.of() [1] which was added in JDK
11 as indicated in the class doc of Paths:
API Note:
It is recommended to obtain a Path via the Path.of methods instead of via the
get methods defined in this class as this class may be deprecated in a future
Andy,
I was just curios why we don't use Paths. If we should then I'll use
this API in my patches. I didn't mean to ask you do the clean up in all
the sources :)
- Alexey
On 6/13/2019 3:34 PM, Andy Herrick wrote:
On 6/13/19, 2:00 PM, Alexey Semenyuk wrote:
Looks good.
Q: any good
On 6/13/19, 2:00 PM, Alexey Semenyuk wrote:
Looks good.
Q: any good reason we are not using
Paths.get(a, b, c)
instead of
a + File.separator + b + File.separator + c
to build paths?
There are a lot of places we should be using Paths instead of String and
File objects, but JPackagePath (test
Looks good.
Q: any good reason we are not using
Paths.get(a, b, c)
instead of
a + File.separator + b + File.separator + c
to build paths?
- Alexey
On 6/13/2019 1:21 PM, Andy Herrick wrote:
Sorry - subject was missing, this is for: JDK-8225569: jpackage
app-image layout
/Andy
On 6/13/2019
Sorry - subject was missing, this is for: JDK-8225569: jpackage
app-image layout
/Andy
On 6/13/2019 12:59 PM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
[1]
12 matches
Mail list logo
