Re: RFR: JDK-8226599 use code coverage results to remove dead code

2019-06-27 Thread Andy Herrick
I would like to rename the other tests too, as well as moving tests up out of directories named for the previous "modes", but I think that should all be a separate changeset. I'd like to leave these name changes in linux and macosx installers for now to promote discussion of the final test

Re: RFR: JDK-8226599 use code coverage results to remove dead code

2019-06-26 Thread Alexander Matveev
Hi Andy, Why only some tests are renamed? Otherwise looks fine. Thanks, Alexander On 6/26/2019 4:09 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1]

Re: RFR: JDK-8226599 use code coverage results to remove dead code

2019-06-26 Thread Alexey Semenyuk
Looks good. - Alexey On 6/26/2019 7:09 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8226599 [2]

RFR: JDK-8226599 use code coverage results to remove dead code

2019-06-26 Thread Andy Herrick
Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8226599 [2] http://cr.openjdk.java.net/~herrick/8226599/webrev.03 /Andy