Re: RFR: JDK-8227172: revert JDK-8225569 on windows

2019-08-12 Thread Alexander Matveev
Looks good. On 8/10/2019 3:44 AM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). This change will remove the "bin" directory on windows and revert to putting the executable(s)

Re: RFR: JDK-8227172: revert JDK-8225569 on windows

2019-08-12 Thread Alexey Semenyuk
Looks good. - Alexey On 8/10/2019 6:44 AM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). This change will remove the "bin" directory on windows and revert to putting the exec

Re: RFR: JDK-8227172: revert JDK-8225569 on windows

2019-08-10 Thread Kevin Rushforth
Looks good. -- Kevin On 8/10/2019 3:44 AM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). This change will remove the "bin" directory on windows and revert to putting the exec

RFR: JDK-8227172: revert JDK-8225569 on windows

2019-08-10 Thread Andy Herrick
Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). This change will remove the "bin" directory on windows and revert to putting the executable(s) directly in output root dir. (dir>/) [1] https://bugs.