Re: RFR: JDK-8234284: [dmg] Change DMG background image to TIFF

2019-12-11 Thread Alexey Semenyuk
Looks good. - Alexey On 12/10/2019 10:24 PM, Alexander Matveev wrote: Please review fix [2] for jpackage bug [1].  - Changed background image for DMG to TIFF format, which can be used to embed 2x image to support HiDPI displays. Thanks, Alexander [1] https://bugs.openjdk.java.net/browse/JD

Re: RFR: JDK-8234284: [dmg] Change DMG background image to TIFF

2019-12-11 Thread Erik Joelsson
Build change looks good. /Erik On 2019-12-11 06:54, Andy Herrick wrote: Fix looks fine to me. adding build-dev since even this simple a makefile change should be reviewed by build-dev On 12/10/2019 10:24 PM, Alexander Matveev wrote: Please review fix [2] for jpackage bug [1].  - Changed b

Re: RFR: JDK-8234284: [dmg] Change DMG background image to TIFF

2019-12-11 Thread Andy Herrick
Fix looks fine to me. adding build-dev since even this simple a makefile change should be reviewed by build-dev On 12/10/2019 10:24 PM, Alexander Matveev wrote: Please review fix [2] for jpackage bug [1].  - Changed background image for DMG to TIFF format, which can be used to embed 2x imag

RFR: JDK-8234284: [dmg] Change DMG background image to TIFF

2019-12-10 Thread Alexander Matveev
Please review fix [2] for jpackage bug [1].  - Changed background image for DMG to TIFF format, which can be used to embed 2x image to support HiDPI displays. Thanks, Alexander [1] https://bugs.openjdk.java.net/browse/JDK-8234284 [2] http://cr.openjdk.java.net/~almatvee/8234284/webrev.00/