Re: RFR: JDK-8235903: GCC default -fno-common exposes "multiple definition" link errors

2019-12-17 Thread Chris Hegarty
om: Martin Buchholz > Sent: Monday, December 16, 2019 10:44 AM > To: Patrick Zhang OS ; net-dev > ; OpenJDK > Cc: core-libs-dev > Subject: Re: RFR: JDK-8235903: GCC default -fno-common exposes "multiple > definition" link errors > > forwarded to othe

RE: RFR: JDK-8235903: GCC default -fno-common exposes "multiple definition" link errors

2019-12-16 Thread Patrick Zhang OS
://bugs.openjdk.java.net/browse/JDK-8235903 Webrev: http://cr.openjdk.java.net/~qpzhang/8235903/webrev.01/ Regards Patrick From: Martin Buchholz Sent: Monday, December 16, 2019 10:44 AM To: Patrick Zhang OS ; net-dev ; OpenJDK Cc: core-libs-dev Subject: Re: RFR: JDK-8235903: GCC default -fno-common exposes

Re: RFR: JDK-8235903: GCC default -fno-common exposes "multiple definition" link errors

2019-12-15 Thread Martin Buchholz
forwarded to other teams for review. On Fri, Dec 13, 2019 at 3:14 AM Patrick Zhang OS < patr...@os.amperecomputing.com> wrote: > Hi > > Please review this patch, if it should be reviewed by any group other than > core-libs, please help forward it. Thanks. > > JBS: https://bugs.openjdk.java.net/br

Re: RFR: JDK-8235903: GCC default -fno-common exposes "multiple definition" link errors

2019-12-15 Thread Martin Buchholz
Looks good to me.

RFR: JDK-8235903: GCC default -fno-common exposes "multiple definition" link errors

2019-12-13 Thread Patrick Zhang OS
Hi Please review this patch, if it should be reviewed by any group other than core-libs, please help forward it. Thanks. JBS: https://bugs.openjdk.java.net/browse/JDK-8235903 Webrev: http://cr.openjdk.java.net/~qpzhang/8235903/webrev.01/ A recent GCC patch (supposed to be in GCC 10) exposes a