Joelsson ; core-libs-dev ; build-dev ; Langer,
Christoph
Subject: Re: RFR: JDK-8238225: Issues reported after replacing
symlink at
Contents/MacOS/libjli.dylib with binary
On 2020-02-04 18:45, Erik Joelsson wrote:
Does anyone have an opinion on this?
The solution seems sound to me. I'm having
Hi Erik,
> Hello,
>
> New webrev: http://cr.openjdk.java.net/~erikj/8238225/webrev.02/
>
> On 2020-02-05 02:17, Langer, Christoph wrote:
> > Hi,
> >
> > we've tested the patch and all reported failure scenarios we're aware of
> are fixed with that, so basically, ship it 😊
> >
> > As for the code
rect for everyone (hence the "something like"
wording) but I see your point. Changed it.
/Erik
Thanks
Christoph
-Original Message-
From: Magnus Ihse Bursie
Sent: Mittwoch, 5. Februar 2020 10:54
To: Erik Joelsson ; core-libs-dev ; build-dev ; Langer,
Christoph
Subject:
on ; core-libs-dev d...@openjdk.java.net>; build-dev ; Langer,
> Christoph
> Subject: Re: RFR: JDK-8238225: Issues reported after replacing symlink at
> Contents/MacOS/libjli.dylib with binary
>
> On 2020-02-04 18:45, Erik Joelsson wrote:
> > Does anyone have an opinion on this?
On 2020-02-04 18:45, Erik Joelsson wrote:
Does anyone have an opinion on this?
The solution seems sound to me. I'm having a hard time figuring out if
the string manipulations in java_md_macosx.m are correct; as Christoph
is saying, they might not be. I realize you have copied an existing
patte
Hi Erik,
> Does anyone have an opinion on this?
Yep, first of all, thanks for doing this work. Sorry for not replying earlier
but FOSDEM/openjdkcw has kept us a bit busy. We're in the process of testing
your change in the reported cases where behavior is broken and shall supply you
with result
On 04/02/2020 17:45, Erik Joelsson wrote:
Does anyone have an opinion on this?
I think this looks okay, would be good if Henry could look at it too as
we've been bitten by changes in this area, I think with Eclipse Tools
that are locating in unusual ways (we think Info.plist). I was happy to
s
Does anyone have an opinion on this?
/Erik
On 2020-01-31 07:31, Erik Joelsson wrote:
In JDK-8235687 the MacOS bundle distribution of the JDK was changed to
conform to Apple requirements by changing Contents/MacOS/libjli.dylib
from a symlink into ../Home/lib/libjli.dylib to a copy of that file.
In JDK-8235687 the MacOS bundle distribution of the JDK was changed to
conform to Apple requirements by changing Contents/MacOS/libjli.dylib
from a symlink into ../Home/lib/libjli.dylib to a copy of that file. The
problem with having a symlink there is that Contents/MacOS/libjli.dylib
is the de