Re: RFR: JDK-8240148: Uncaught exceptions from ScheduledThreadPoolExecutor.execute aren't reported

2020-06-24 Thread Jaikiran Pai
Thank you both Martin and David for your inputs. On 25/06/20 5:40 am, David Holmes wrote: > Hi Jaikiran, > > >> The patch is available as a webrev at >> https://cr.openjdk.java.net/~jpai/webrev/8240148/1/ >> >> The patch updates the ScheduledThreadPoolExecutor.execute(Runnable) to >> wrap the

Re: RFR: JDK-8240148: Uncaught exceptions from ScheduledThreadPoolExecutor.execute aren't reported

2020-06-24 Thread David Holmes
Hi Jaikiran, On 24/06/2020 11:44 pm, Jaikiran Pai wrote: Could I please get a review and a sponsor for a fix for https://bugs.openjdk.java.net/browse/JDK-8240148? I missed the filing of this bug. :( The patch is available as a webrev at https://cr.openjdk.java.net/~jpai/webrev/8240148/1/

Re: RFR: JDK-8240148: Uncaught exceptions from ScheduledThreadPoolExecutor.execute aren't reported

2020-06-24 Thread Martin Buchholz
Thanks for your work on this. Invoking the UEH machinery directly is extremely unusual and would never have occurred to me (outside of a test). In a loom-directed world, any attempt to directly manipulate the current thread is likely to lead to trouble. This code is primarily maintained

RFR: JDK-8240148: Uncaught exceptions from ScheduledThreadPoolExecutor.execute aren't reported

2020-06-24 Thread Jaikiran Pai
Could I please get a review and a sponsor for a fix for https://bugs.openjdk.java.net/browse/JDK-8240148? The patch is available as a webrev at https://cr.openjdk.java.net/~jpai/webrev/8240148/1/ The patch updates the ScheduledThreadPoolExecutor.execute(Runnable) to wrap the user passed Runnable