Re: RFR: JDK-8241742 - Remove the preview status for methods introduced for Text Blocks

I see the `@since` tags have not been updated, and that there is still `{@preview}` text in the doc comment? Does this need a followup bug? -- Jon On 4/6/20 10:30 AM, Jim Laskey wrote: fixed the @bug - thx Alan On Apr 6, 2020, at 2:12 PM, Alan Bateman wrote: On 06/04/2020 16:54, Jim

Re: RFR: JDK-8241742 - Remove the preview status for methods introduced for Text Blocks

fixed the @bug - thx Alan > On Apr 6, 2020, at 2:12 PM, Alan Bateman wrote: > > On 06/04/2020 16:54, Jim Laskey wrote: >> Updated webrev: http://cr.openjdk.java.net/~jlaskey/8241742/webrev-00 >> >> >> > I assume this this updated webrev:

Re: RFR: JDK-8241742 - Remove the preview status for methods introduced for Text Blocks

On 06/04/2020 16:54, Jim Laskey wrote: Updated webrev: http://cr.openjdk.java.net/~jlaskey/8241742/webrev-00 I assume this this updated webrev:   http://cr.openjdk.java.net/~jlaskey/8241742/webrev-01/ I asked Jim off-list about the @sin

Re: RFR: JDK-8241742 - Remove the preview status for methods introduced for Text Blocks

> On 6 Apr 2020, at 17:03, Paul Sandoz wrote: > > ... >> On Apr 6, 2020, at 8:54 AM, Jim Laskey wrote: >> >> Updated webrev: http://cr.openjdk.java.net/~jlaskey/8241742/webrev-00 >> Woohoo. LGTM. -Chris.

Re: RFR: JDK-8241742 - Remove the preview status for methods introduced for Text Blocks

+1 Paul. > On Apr 6, 2020, at 8:54 AM, Jim Laskey wrote: > > Updated webrev: http://cr.openjdk.java.net/~jlaskey/8241742/webrev-00 > > >> On Apr 6, 2020, at 11:40 AM, Jim Laskey wrote: >> >> Please take the time to review the code chan

Re: RFR: JDK-8241742 - Remove the preview status for methods introduced for Text Blocks

Updated webrev: http://cr.openjdk.java.net/~jlaskey/8241742/webrev-00 > On Apr 6, 2020, at 11:40 AM, Jim Laskey wrote: > > Please take the time to review the code changes to remove preview status for > String::stripIndent, String::transla

RFR: JDK-8241742 - Remove the preview status for methods introduced for Text Blocks

Please take the time to review the code changes to remove preview status for String::stripIndent, String::translateEscapes and String::formatted. The changes are pretty light-weight and shouldn't take too long to review. Mostly involves removing "preview" trappings. Cheers, -- Jim webrev: htt