Re: RFR: JDK-8249258 java/util/StringJoiner/StringJoinerTest.java failed due to OOM (JDK 15)

2020-07-15 Thread Jim Laskey
In StringJoiner::toString final int addLen = prefix.length() + suffix.length(); Looks suspicious. There is no check for overflow here. Looking at the constructor it should have raised a OOM much earlier. Will investigate and file a bug. Thanks. -- Jim > On Jul 15, 2020, at 1:21 PM,

Re: RFR: JDK-8249258 java/util/StringJoiner/StringJoinerTest.java failed due to OOM (JDK 15)

2020-07-15 Thread Thomas Schatzl
Hi, I looked a bit at the allocations themselves, but first answering questions. On 15.07.20 15:25, David Holmes wrote: > On 15/07/2020 10:18 pm, Jim Laskey wrote: >> Thomas explained: That large objects are never moved (outstanding >> issue) So, it's possible to fragment the -Xmx4g such tha

Re: RFR: JDK-8249258 java/util/StringJoiner/StringJoinerTest.java failed due to OOM (JDK 15)

2020-07-15 Thread Thomas Schatzl
Hi, On 15.07.20 15:35, Jim Laskey wrote: Try this: - You have a 4G heap. - You allocate some stuff, say 1 byte. - You allocate a 2G object - so there is only 2G - 1, left. Not enough space for another 2G object. - But you do allocate 1 byte. - You have 1 byte, 2G and 1 byte. - You free the ori

Re: RFR: JDK-8249258 java/util/StringJoiner/StringJoinerTest.java failed due to OOM (JDK 15)

2020-07-15 Thread Jim Laskey
mpossible for the same >>>> "repeat" call to hit an OOME in OOM3. Unless the test is being run >>>> concurrrently in the same VM as other tests? >>>> >>>> Cheers, >>>> David >>>> >>>>> Thanks, Roger >>>>>

Re: RFR: JDK-8249258 java/util/StringJoiner/StringJoinerTest.java failed due to OOM (JDK 15)

2020-07-15 Thread David Holmes
Laskey mailto:james.las...@oracle.com>> *Subject: **RFR: JDK-8249258 java/util/StringJoiner/StringJoinerTest.java failed due to OOM (JDK 15)* *Date: *July 14, 2020 at 2:01:09 PM ADT *To: *core-libs-dev mailto:core-libs-dev@openjdk.java.net>> The test was failing on a newly added mac min

Re: RFR: JDK-8249258 java/util/StringJoiner/StringJoinerTest.java failed due to OOM (JDK 15)

2020-07-15 Thread Jim Laskey
;> Cheers, >> David >> >>> Thanks, Roger >>> On 7/14/20 2:23 PM, Daniel D. Daugherty wrote: >>>> On 7/14/20 2:09 PM, Jim Laskey wrote: >>>>> Adding Daniel >>>>> >>>>>> Begin forwarded message: >>>&g

Re: RFR: JDK-8249258 java/util/StringJoiner/StringJoinerTest.java failed due to OOM (JDK 15)

2020-07-15 Thread Jim Laskey
avid > >> Thanks, Roger >> On 7/14/20 2:23 PM, Daniel D. Daugherty wrote: >>> On 7/14/20 2:09 PM, Jim Laskey wrote: >>>> Adding Daniel >>>> >>>>> Begin forwarded message: >>>>> >>>>> *From: *Jim Lask

Re: Fwd: RFR: JDK-8249258 java/util/StringJoiner/StringJoinerTest.java failed due to OOM (JDK 15)

2020-07-14 Thread David Holmes
ers, David Thanks, Roger On 7/14/20 2:23 PM, Daniel D. Daugherty wrote: On 7/14/20 2:09 PM, Jim Laskey wrote: Adding Daniel Begin forwarded message: *From: *Jim Laskey <mailto:james.las...@oracle.com>> *Subject: **RFR: JDK-8249258 java/util/StringJoiner/StringJoinerTest.java fa

Re: Fwd: RFR: JDK-8249258 java/util/StringJoiner/StringJoinerTest.java failed due to OOM (JDK 15)

2020-07-14 Thread Roger Riggs
Laskey <mailto:james.las...@oracle.com>> *Subject: **RFR: JDK-8249258 java/util/StringJoiner/StringJoinerTest.java failed due to OOM (JDK 15)* *Date: *July 14, 2020 at 2:01:09 PM ADT *To: *core-libs-dev <mailto:core-libs-dev@openjdk.java.net>> The test was failing on a newly ad

Re: Fwd: RFR: JDK-8249258 java/util/StringJoiner/StringJoinerTest.java failed due to OOM (JDK 15)

2020-07-14 Thread Daniel D. Daugherty
On 7/14/20 2:09 PM, Jim Laskey wrote: Adding Daniel Begin forwarded message: *From: *Jim Laskey <mailto:james.las...@oracle.com>> *Subject: **RFR: JDK-8249258 java/util/StringJoiner/StringJoinerTest.java failed due to OOM (JDK 15)* *Date: *July 14, 2020 at 2:01:09 PM ADT *To: *core

Fwd: RFR: JDK-8249258 java/util/StringJoiner/StringJoinerTest.java failed due to OOM (JDK 15)

2020-07-14 Thread Jim Laskey
Adding Daniel > Begin forwarded message: > > From: Jim Laskey > Subject: RFR: JDK-8249258 java/util/StringJoiner/StringJoinerTest.java failed > due to OOM (JDK 15) > Date: July 14, 2020 at 2:01:09 PM ADT > To: core-libs-dev > > The test was failing on a newly a

RFR: JDK-8249258 java/util/StringJoiner/StringJoinerTest.java failed due to OOM (JDK 15)

2020-07-14 Thread Jim Laskey
The test was failing on a newly added mac mini. I've reduced the memory stress by introducing a shared maximum sized string. I don't recommend reducing the 4G memory requirement -- multiple new large objects are constructed in the tests hoping to create an OOM. JBS: https://bugs.openjdk.java.ne