Re: RFR: JDK-8254920: Application launched with jpackage produced .exe crashes JVM [v3]

2020-11-05 Thread Alexander Zuev
On Thu, 5 Nov 2020 18:18:16 GMT, Andy Herrick wrote: >> JVM > > Andy Herrick has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains three additional > co

Re: RFR: JDK-8254920: Application launched with jpackage produced .exe crashes JVM [v3]

2020-11-05 Thread Andy Herrick
> JVM Andy Herrick has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into jdk

Re: RFR: JDK-8254920: Application launched with jpackage produced .exe crashes JVM [v2]

2020-10-30 Thread Alexander Matveev
On Fri, 30 Oct 2020 12:47:08 GMT, Andy Herrick wrote: >> JVM > > Andy Herrick has updated the pull request incrementally with one additional > commit since the last revision: > > JDK-8254920: Application launched with jpackage produced .exe crashes JVM Marked as reviewed by almatvee (Committ

Re: RFR: JDK-8254920: Application launched with jpackage produced .exe crashes JVM [v2]

2020-10-30 Thread Alexey Semenyuk
On Fri, 30 Oct 2020 12:47:08 GMT, Andy Herrick wrote: >> JVM > > Andy Herrick has updated the pull request incrementally with one additional > commit since the last revision: > > JDK-8254920: Application launched with jpackage produced .exe crashes JVM Marked as reviewed by asemenyuk (Commit

Re: RFR: JDK-8254920: Application launched with jpackage produced .exe crashes JVM [v2]

2020-10-30 Thread Andy Herrick
> JVM Andy Herrick has updated the pull request incrementally with one additional commit since the last revision: JDK-8254920: Application launched with jpackage produced .exe crashes JVM - Changes: - all: https://git.openjdk.java.net/jdk/pull/940/files - new: https://git.ope

Re: RFR: JDK-8254920: Application launched with jpackage produced .exe crashes JVM

2020-10-29 Thread Alexey Semenyuk
On Thu, 29 Oct 2020 17:32:24 GMT, Andy Herrick wrote: > JVM test/jdk/tools/jpackage/helpers/jdk/jpackage/test/HelloApp.java line 276: > 274: AppOutputVerifier av = getVerifier(cmd, args); > 275: if (av != null) { > 276: // when running app launchers, clear users envi

RFR: JDK-8254920: Application launched with jpackage produced .exe crashes JVM

2020-10-29 Thread Andy Herrick
JVM - Commit messages: - JDK-8254920: Application launched with jpackage produced .exe crashes Changes: https://git.openjdk.java.net/jdk/pull/940/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=940&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8254920 Sta