Re: RFR: JDK-8264055: backout JDK-8248904 in order to resubmit with additional attribution.

2021-03-23 Thread Alexey Semenyuk
On Tue, 23 Mar 2021 17:09:20 GMT, Andy Herrick wrote: > We are backing out the fix to "JDK-8248904 Add support to jpackage for the > Mac App Store " in order to resubmit with added contributor attribution for > Erwin Morrhey > This is the backout. Marked as reviewed by asemenyuk (Reviewer). -

Re: RFR: JDK-8264055: backout JDK-8248904 in order to resubmit with additional attribution.

2021-03-23 Thread Victor Dyakov
On Tue, 23 Mar 2021 19:40:38 GMT, Kevin Rushforth wrote: >>> Looks good, although i see the following wasn't backed out: >>> >>> ``` >>> src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/JavaApp.icns >>> ``` >> >> yes - look again - it was renamed back to java.icns (the 12'th or 2

Re: RFR: JDK-8264055: backout JDK-8248904 in order to resubmit with additional attribution.

2021-03-23 Thread Victor Dyakov
On Tue, 23 Mar 2021 20:42:22 GMT, Victor Dyakov wrote: >> As long as there are no transient build/test failures, it will be fine. I >> was just comparing the results with what `git revert >> 11c8c78c47f21fcd87a5969a859b5c4fced5e47d` generated and noticed this >> difference. > > @sashamatveev p

Re: RFR: JDK-8264055: backout JDK-8248904 in order to resubmit with additional attribution.

2021-03-23 Thread Kevin Rushforth
On Tue, 23 Mar 2021 18:17:00 GMT, Andy Herrick wrote: >> Looks good, although i see the following wasn't backed out: >> >> src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/JavaApp.icns >> >> If this is intentional, then no need to worry about it. > >> Looks good, although i see t

Re: RFR: JDK-8264055: backout JDK-8248904 in order to resubmit with additional attribution.

2021-03-23 Thread Andy Herrick
On Tue, 23 Mar 2021 17:55:24 GMT, Kevin Rushforth wrote: > Looks good, although i see the following wasn't backed out: > > ``` > src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/JavaApp.icns > ``` yes - look again - it was renamed back to java.icns (the 12'th or 22 files changed

Re: RFR: JDK-8264055: backout JDK-8248904 in order to resubmit with additional attribution.

2021-03-23 Thread Kevin Rushforth
On Tue, 23 Mar 2021 17:09:20 GMT, Andy Herrick wrote: > We are backing out the fix to "JDK-8248904 Add support to jpackage for the > Mac App Store " in order to resubmit with added contributor attribution for > Erwin Morrhey > This is the backout. Looks good, although i see the following wasn'

RFR: JDK-8264055: backout JDK-8248904 in order to resubmit with additional attribution.

2021-03-23 Thread Andy Herrick
We are backing out the fix to "JDK-8248904 Add support to jpackage for the Mac App Store " in order to resubmit with added contributor attribution for Erwin Morrhey This is the backout. - Commit messages: - JDK-8264055: backout JDK-8248904 in order to resubmit with additional attr