Re: RFR: JDK-8277520: Implement JDK-8 default methods for IdentityHashMap [v4]

2022-04-20 Thread ExE Boss
On Mon, 21 Feb 2022 23:36:19 GMT, liach wrote: >> Might need a CSR as now `computeIfAbsent` `computeIfPresent` `compute` >> `merge` would throw CME if the functions modified the map itself, and there >> are corresponding specification changes. > > liach has updated the pull request incrementall

Re: RFR: JDK-8277520: Implement JDK-8 default methods for IdentityHashMap [v4]

2022-04-17 Thread ExE Boss
On Sat, 19 Mar 2022 19:46:19 GMT, ExE Boss wrote: >> liach has updated the pull request incrementally with two additional commits >> since the last revision: >> >> - merge branch 'identityhashmap-bench' of >> https://github.com/liachmodded/jdk into identityhashmap-default >> - fix whitespace

Re: RFR: JDK-8277520: Implement JDK-8 default methods for IdentityHashMap [v4]

2022-03-19 Thread liach
On Mon, 21 Feb 2022 23:36:19 GMT, liach wrote: >> Might need a CSR as now `computeIfAbsent` `computeIfPresent` `compute` >> `merge` would throw CME if the functions modified the map itself, and there >> are corresponding specification changes. > > liach has updated the pull request incrementall

Re: RFR: JDK-8277520: Implement JDK-8 default methods for IdentityHashMap [v4]

2022-03-19 Thread ExE Boss
On Mon, 21 Feb 2022 23:36:19 GMT, liach wrote: >> Might need a CSR as now `computeIfAbsent` `computeIfPresent` `compute` >> `merge` would throw CME if the functions modified the map itself, and there >> are corresponding specification changes. > > liach has updated the pull request incrementall

Re: RFR: JDK-8277520: Implement JDK-8 default methods for IdentityHashMap [v4]

2022-03-19 Thread liach
On Sat, 19 Mar 2022 00:45:14 GMT, Stuart Marks wrote: >> @stuart-marks Could you help me with this? >> >> In my JMH benchmark runs, I often find that ambient differences (from the >> jdk processes, the random test data generated, etc.) hide the actual >> performance difference caused by the pa

Re: RFR: JDK-8277520: Implement JDK-8 default methods for IdentityHashMap [v4]

2022-03-19 Thread ExE Boss
On Sat, 19 Mar 2022 00:45:14 GMT, Stuart Marks wrote: >> @stuart-marks Could you help me with this? >> >> In my JMH benchmark runs, I often find that ambient differences (from the >> jdk processes, the random test data generated, etc.) hide the actual >> performance difference caused by the pa

Re: RFR: JDK-8277520: Implement JDK-8 default methods for IdentityHashMap [v4]

2022-03-18 Thread Stuart Marks
On Wed, 16 Mar 2022 17:16:06 GMT, liach wrote: >> liach has updated the pull request incrementally with two additional commits >> since the last revision: >> >> - merge branch 'identityhashmap-bench' of >> https://github.com/liachmodded/jdk into identityhashmap-default >> - fix whitespace >

Re: RFR: JDK-8277520: Implement JDK-8 default methods for IdentityHashMap [v4]

2022-03-16 Thread liach
On Mon, 21 Feb 2022 23:36:19 GMT, liach wrote: >> Might need a CSR as now `computeIfAbsent` `computeIfPresent` `compute` >> `merge` would throw CME if the functions modified the map itself, and there >> are corresponding specification changes. > > liach has updated the pull request incrementall

Re: RFR: JDK-8277520: Implement JDK-8 default methods for IdentityHashMap [v4]

2022-02-21 Thread liach
> Might need a CSR as now `computeIfAbsent` `computeIfPresent` `compute` > `merge` would throw CME if the functions modified the map itself, and there > are corresponding specification changes. liach has updated the pull request incrementally with two additional commits since the last revision:

Re: RFR: JDK-8277520: Implement JDK-8 default methods for IdentityHashMap [v3]

2022-02-21 Thread liach
On Mon, 21 Feb 2022 22:27:34 GMT, liach wrote: >> Might need a CSR as now `computeIfAbsent` `computeIfPresent` `compute` >> `merge` would throw CME if the functions modified the map itself, and there >> are corresponding specification changes. > > liach has updated the pull request with a new t

Re: RFR: JDK-8277520: Implement JDK-8 default methods for IdentityHashMap [v3]

2022-02-21 Thread liach
> Might need a CSR as now `computeIfAbsent` `computeIfPresent` `compute` > `merge` would throw CME if the functions modified the map itself, and there > are corresponding specification changes. liach has updated the pull request with a new target base due to a merge or a rebase. The incremental

Re: RFR: JDK-8277520: Implement JDK-8 default methods for IdentityHashMap [v2]

2022-02-11 Thread liach
On Thu, 16 Dec 2021 20:48:39 GMT, liach wrote: >> Might need a CSR as now `computeIfAbsent` `computeIfPresent` `compute` >> `merge` would throw CME if the functions modified the map itself, and there >> are corresponding specification changes. > > liach has updated the pull request with a new t

Re: RFR: JDK-8277520: Implement JDK-8 default methods for IdentityHashMap [v2]

2022-01-14 Thread Roger Riggs
On Thu, 16 Dec 2021 20:48:39 GMT, liach wrote: >> Might need a CSR as now `computeIfAbsent` `computeIfPresent` `compute` >> `merge` would throw CME if the functions modified the map itself, and there >> are corresponding specification changes. > > liach has updated the pull request with a new t

Re: RFR: JDK-8277520: Implement JDK-8 default methods for IdentityHashMap [v2]

2022-01-13 Thread liach
On Thu, 16 Dec 2021 20:48:39 GMT, liach wrote: >> Might need a CSR as now `computeIfAbsent` `computeIfPresent` `compute` >> `merge` would throw CME if the functions modified the map itself, and there >> are corresponding specification changes. > > liach has updated the pull request with a new t

Re: RFR: JDK-8277520: Implement JDK-8 default methods for IdentityHashMap [v2]

2021-12-16 Thread liach
> Might need a CSR as now `computeIfAbsent` `computeIfPresent` `compute` > `merge` would throw CME if the functions modified the map itself, and there > are corresponding specification changes. liach has updated the pull request with a new target base due to a merge or a rebase. The incremental

Re: RFR: JDK-8277520: Implement JDK-8 default methods for IdentityHashMap

2021-12-14 Thread liach
On Wed, 24 Nov 2021 05:16:40 GMT, liach wrote: > Might need a CSR as now `computeIfAbsent` `computeIfPresent` `compute` > `merge` would throw CME if the functions modified the map itself, and there > are corresponding specification changes. Just curious, what else is recommended for such addit

Re: RFR: JDK-8277520: Implement JDK-8 default methods for IdentityHashMap

2021-12-06 Thread Joseph D. Darcy
On 12/4/2021 4:31 PM, liach wrote: On Wed, 24 Nov 2021 05:16:40 GMT, liach wrote: Might need a CSR as now `computeIfAbsent` `computeIfPresent` `compute` `merge` would throw CME if the functions modified the map itself, and there are corresponding specification changes. Since I don't have

Re: RFR: JDK-8277520: Implement JDK-8 default methods for IdentityHashMap

2021-12-04 Thread liach
On Wed, 24 Nov 2021 05:16:40 GMT, liach wrote: > Might need a CSR as now `computeIfAbsent` `computeIfPresent` `compute` > `merge` would throw CME if the functions modified the map itself, and there > are corresponding specification changes. Since I don't have an account on the JBS, I will post

Re: RFR: JDK-8277520: Implement JDK-8 default methods for IdentityHashMap

2021-12-04 Thread Joe Darcy
On Wed, 24 Nov 2021 05:16:40 GMT, liach wrote: > Might need a CSR as now `computeIfAbsent` `computeIfPresent` `compute` > `merge` would throw CME if the functions modified the map itself, and there > are corresponding specification changes. Yes, behavioral changes in a widely-used class would

RFR: JDK-8277520: Implement JDK-8 default methods for IdentityHashMap

2021-11-23 Thread liach
Might need a CSR as now `computeIfAbsent` `computeIfPresent` `compute` `merge` would throw CME if the functions modified the map itself, and there are corresponding specification changes. - Commit messages: - Also test cme for identity hash map - Fix putIfAbsent - JDK-8277520: Im