Re: RFR: docs JDK-8220261: fix headings in java.base

2019-03-20 Thread Mandy Chung
I looked through the webrev and this looks fine to me. Mandy On 3/20/19 2:50 PM, Jonathan Gibbons wrote: Please review a medium-sized but conceptually simple patch to fix most of the headings in the generated documentation for java.base, as described in [1]. This does not address the headings

Re: RFR: docs JDK-8220261: fix headings in java.base

2019-03-20 Thread Jonathan Gibbons
Thanks. -- Jon On 03/20/2019 03:16 PM, Lance Andersen wrote: Hi Jon, I went through the patch and it looks good (matches what i did for java.sql.rowset and java.naming :-) ) On Mar 20, 2019, at 5:50 PM, Jonathan Gibbons mailto:jonathan.gibb...@oracle.com>> wrote: JDK-8220248

Re: RFR: docs JDK-8220261: fix headings in java.base

2019-03-20 Thread Lance Andersen
Hi Jon, I went through the patch and it looks good (matches what i did for java.sql.rowset and java.naming :-) ) > On Mar 20, 2019, at 5:50 PM, Jonathan Gibbons > wrote: > > JDK-8220248

RFR: docs JDK-8220261: fix headings in java.base

2019-03-20 Thread Jonathan Gibbons
Please review a medium-sized but conceptually simple patch to fix most of the headings in the generated documentation for java.base, as described in [1]. This does not address the headings in java.util.concurrent which are reported separately, in JDK-8220248. The intent is to ensure that the h