Re: RFR:JDK-8031085:DateTimeFormatter won't parse dates with custom format "yyyyMMddHHmmssSSS"

Hi Roger, Please see the updated webrev http://cr.openjdk.java.net/~ntv/8031085/webrev.02/ Regards, Nadeesh TV On 4/19/2016 10:51 PM, Roger Riggs wrote: Hi Nadeesh, java/time/format/DateTimeFormatterBuilder.java: - line 671, the @code should be @link, especially since it says "see", to

Re: RFR:JDK-8031085:DateTimeFormatter won't parse dates with custom format "yyyyMMddHHmmssSSS"

Hi Nadeesh, java/time/format/DateTimeFormatterBuilder.java: - line 671, the @code should be @link, especially since it says "see", to make navigation easier - line 2998: Missing first sentence of the method description. otherwise looks ok. Roger On 4/19/2016 10:16 AM, Stephen

Re: RFR:JDK-8031085:DateTimeFormatter won't parse dates with custom format "yyyyMMddHHmmssSSS"

Looks good. Stephen On 19 April 2016 at 09:42, nadeesh tv wrote: > Hi Stephen, > > Thanks for the comments. > Please see the updated webrev > http://cr.openjdk.java.net/~ntv/8031085/webrev.01/ > > -- > Thanks and Regards, > Nadeesh TV > > > > > On 4/18/2016 3:03 AM,

Re: RFR:JDK-8031085:DateTimeFormatter won't parse dates with custom format "yyyyMMddHHmmssSSS"

Hi Stephen, Thanks for the comments. Please see the updated webrev http://cr.openjdk.java.net/~ntv/8031085/webrev.01/ -- Thanks and Regards, Nadeesh TV On 4/18/2016 3:03 AM, Stephen Colebourne wrote: The updated spec at line 670 is not clear - the adjacent parsing mode only applies when

Re: RFR:JDK-8031085:DateTimeFormatter won't parse dates with custom format "yyyyMMddHHmmssSSS"

The updated spec at line 670 is not clear - the adjacent parsing mode only applies when in strict mode. Suggest a new sentence before the lenient mode one: "In strict mode, if the minimum and maximum widths are equal and there is no decimal point then the parser will participate in adjacent value

RFR:JDK-8031085:DateTimeFormatter won't parse dates with custom format "yyyyMMddHHmmssSSS"

HI all, BUG ID : https://bugs.openjdk.java.net/browse/JDK-8031085 Webrev : http://cr.openjdk.java.net/~ntv/8031085/webrev.00/ Issue - Fractional parts of seconds do not participate in the protocol for adjacent value parsing Solution - Changed the FractionPrinterParser to subclass of