RFR:JDK-8072746:LocalDate.isEra() should return IsoEra not Era

2015-11-13 Thread nadeesh tv
Hi all, Please review a fix for BugId - https://bugs.openjdk.java.net/browse/JDK-8072746 Issue - LocalDate.isEra() should return IsoEra not Era webrev - http://cr.openjdk.java.net/~ntv/8072746/webrev.02

Re: RFR:JDK-8072746:LocalDate.isEra() should return IsoEra not Era

2015-11-13 Thread Roger Riggs
Hi Nadeesh, The @return mentions "ISOChronoloy era constant" and it should probably be a reference to IsoEra. Also make it a link {@link java.time.chrono.IsoEra IsoEra} Otherwise looks good. Thanks, Roger On 11/13/2015 6:06 AM, nadeesh tv wrote: Hi all, Please review a fix for BugId -

Re: RFR:JDK-8072746:LocalDate.isEra() should return IsoEra not Era

2015-11-13 Thread nadeesh tv
Hi all, Please review the updated webrev http://cr.openjdk.java.net/~ntv/8072746/webrev.03/ Thanks and Regards, Nadeesh TV On 11/13/2015 8:40 PM, Roger Riggs wrote: Hi Nadeesh, The @return mentions "ISOChronoloy era constant" and it should probably be a reference to IsoEra. Also make it

Re: RFR:JDK-8072746:LocalDate.isEra() should return IsoEra not Era

2015-11-13 Thread Roger Riggs
Hi Stephen, Yes, it will be reviewed by the JCK team before being integrated (and is conditional on comments). Roger On 11/13/2015 9:14 AM, Stephen Colebourne wrote: I'm happy with the webrev, however I'd like to see an official ruling as to whether this is an acceptable change to the

Re: RFR:JDK-8072746:LocalDate.isEra() should return IsoEra not Era

2015-11-13 Thread Stephen Colebourne
I'm happy with the webrev, however I'd like to see an official ruling as to whether this is an acceptable change to the spec. thanks Stephen On 13 November 2015 at 11:06, nadeesh tv wrote: > Hi all, > > Please review a fix for BugId - >