Re: RFR:JDK-8145633-Adjacent value parsing not supported for Localized Patterns

Hi Nadeesh, Looks fine. It would be more direct to add that "The inherited field NumberPrinterParser.field is unused." No need for another review cycle. Thanks, Roger On 12/21/16 8:24 AM, nadeesh tv wrote: Hi Roger & Stephen, Please see the updated webrev

Re: RFR:JDK-8145633-Adjacent value parsing not supported for Localized Patterns

Updated (13) webrev looks fine (link above is to webrev 12). Stephen On 21 December 2016 at 13:24, nadeesh tv wrote: > Hi Roger & Stephen, > > Please see the updated webrev > http://cr.openjdk.java.net/~ntv/8145633/webrev.13/ > > > On 12/21/2016 3:11 AM, Roger Riggs

Re: RFR:JDK-8145633-Adjacent value parsing not supported for Localized Patterns

Hi Roger & Stephen, Please see the updated webrev http://cr.openjdk.java.net/~ntv/8145633/webrev.13/ On 12/21/2016 3:11 AM, Roger Riggs wrote: Hi Nadeesh, On 12/20/2016 2:34 PM, nadeesh tv wrote: Hi Roger & Stephen , Thanks for the comments. Please see the updated webrev

Re: RFR:JDK-8145633-Adjacent value parsing not supported for Localized Patterns

Hi Nadeesh, On 12/20/2016 2:34 PM, nadeesh tv wrote: Hi Roger & Stephen , Thanks for the comments. Please see the updated webrev http://cr.openjdk.java.net/~ntv/8145633/webrev.12/ Changes included : 1. Doc changes and cosmetic changes suggested by Roger (except the note about delay..)

Re: RFR:JDK-8145633-Adjacent value parsing not supported for Localized Patterns

Hi Roger & Stephen , Thanks for the comments. Please see the updated webrev http://cr.openjdk.java.net/~ntv/8145633/webrev.12/ Changes included : 1. Doc changes and cosmetic changes suggested by Roger (except the note about delay..) 2. Changed the behavior of 'e' to parse only 1 digit

Re: RFR:JDK-8145633-Adjacent value parsing not supported for Localized Patterns

In the test provider_adjacentValuePatterns2(), please add {"wwe", Y, w, c, "20161201", 2016, 12, 1}, This should succeed, because a single number is all that is needed to parse day-of-week. (So, it will need to be removed from the invalid patterns test). Line 1869 will need to change to

Re: RFR:JDK-8145633-Adjacent value parsing not supported for Localized Patterns

Hi Nadeesh, A nice bit of work. DateTimeFormatterBuilder: 4774: A note about the design to delay the choice of TemporalField and creating PrinterParser until the locale is known would be useful 4789: Please add the @param descriptions so the purpose of the new arguments is

RFR:JDK-8145633-Adjacent value parsing not supported for Localized Patterns

Hi all, BugId: https://bugs.openjdk.java.net/browse/JDK-8145633 Issue: Support adjacent value parsing for Localized Patterns Webrev: http://cr.openjdk.java.net/~ntv/8145633/webrev.10/ Pattern 'c' and 'W' were previously allowed to have 'zero padding' which was not explicitly mentioned in