Re: RFR:JDK-8146747:java.time.Duration.toNanos() and toMillis() exception on negative durations

2016-02-04 Thread ShinyaYoshida
Hi, There is no problem. Thank you for the fix! shinyafox(Shinya Yoshida) 2016/02/04 14:28 "nadeesh tv" : > > Hi all, > > Please see the updated webrev > http://cr.openjdk.java.net/~ntv/8146747/webrev.01/ > Regards, > Nadeesh > On 2/3/2016 5:48 PM, nadeesh tv wrote: > >>

Re: RFR:JDK-8146747:java.time.Duration.toNanos() and toMillis() exception on negative durations

2016-02-03 Thread nadeesh tv
Hi Shinya, Thnx. I will update it. Regards, Nadeesh On 2/3/2016 5:41 PM, ShinyaYoshida wrote: Hi Nadeesh, Almost LGTM!(But I'm not a reviewer;) ) However I've noticed that you don't use NANOS_PER_SECOND at L1223 and L1246. Is there some reason not to use it? Regards, shinyafox(Shinya Yoshida)

Re: RFR:JDK-8146747:java.time.Duration.toNanos() and toMillis() exception on negative durations

2016-02-03 Thread ShinyaYoshida
Hi Nadeesh, Almost LGTM!(But I'm not a reviewer;) ) However I've noticed that you don't use NANOS_PER_SECOND at L1223 and L1246. Is there some reason not to use it? Regards, shinyafox(Shinya Yoshida) 2016-02-01 15:18 GMT+09:00 nadeesh tv : > Hi all, > > Please review

Re: RFR:JDK-8146747:java.time.Duration.toNanos() and toMillis() exception on negative durations

2016-02-03 Thread Stephen Colebourne
Yes, looks fine thanks Stephen On 1 February 2016 at 06:18, nadeesh tv wrote: > Hi all, > > Please review following > > Bug Id : https://bugs.openjdk.java.net/browse/JDK-8146747 > > Solution: Handled the negative duration separately > > webrev :

Re: RFR:JDK-8146747:java.time.Duration.toNanos() and toMillis() exception on negative durations

2016-02-03 Thread nadeesh tv
Hi all, Please see the updated webrev http://cr.openjdk.java.net/~ntv/8146747/webrev.01/ Regards, Nadeesh On 2/3/2016 5:48 PM, nadeesh tv wrote: Hi Shinya, Thnx. I will update it. Regards, Nadeesh On 2/3/2016 5:41 PM, ShinyaYoshida wrote: Hi Nadeesh, Almost LGTM!(But I'm not a reviewer;) )

Re: RFR:JDK-8146747:java.time.Duration.toNanos() and toMillis() exception on negative durations

2016-02-02 Thread Roger Riggs
Hi Nadeesh, Looks fine. Roger On 2/1/2016 1:18 AM, nadeesh tv wrote: Hi all, Please review following Bug Id : https://bugs.openjdk.java.net/browse/JDK-8146747 Solution: Handled the negative duration separately webrev :

RFR:JDK-8146747:java.time.Duration.toNanos() and toMillis() exception on negative durations

2016-01-31 Thread nadeesh tv
Hi all, Please review following Bug Id : https://bugs.openjdk.java.net/browse/JDK-8146747 Solution: Handled the negative duration separately webrev : http://cr.openjdk.java.net/~ntv/8146747/webrev.00/