Re: RFR:JDK-8148949:DateTimeFormatter pattern letters 'A','n','N'

+1 Roger On 5/4/2016 6:00 AM, Stephen Colebourne wrote: Fine by me. thanks Stephen On 4 May 2016 at 08:13, nadeesh tv wrote: Hi, Updated the webrev http://cr.openjdk.java.net/~ntv/8148949/webrev.03/ Thanks and Regards, Nadeesh On 5/3/2016 8:37 PM, Stephen

Re: RFR:JDK-8148949:DateTimeFormatter pattern letters 'A','n','N'

Fine by me. thanks Stephen On 4 May 2016 at 08:13, nadeesh tv wrote: > Hi, > > Updated the webrev http://cr.openjdk.java.net/~ntv/8148949/webrev.03/ > > Thanks and Regards, > Nadeesh > > On 5/3/2016 8:37 PM, Stephen Colebourne wrote: >> >> The current behaviour is to use

Re: RFR:JDK-8148949:DateTimeFormatter pattern letters 'A','n','N'

Hi, Updated the webrev http://cr.openjdk.java.net/~ntv/8148949/webrev.03/ Thanks and Regards, Nadeesh On 5/3/2016 8:37 PM, Stephen Colebourne wrote: The current behaviour is to use NORMAL for "A" and NOT_NEGATIVE for "AA", "AAA" and so on. The sensible behaviour going forward is to use

Re: RFR:JDK-8148949:DateTimeFormatter pattern letters 'A','n','N'

The current behaviour is to use NORMAL for "A" and NOT_NEGATIVE for "AA", "AAA" and so on. The sensible behaviour going forward is to use NOT_NEGATIVE for all these, simply because the values do not make sense to be negative. Given how these fields are nigh-on useless as currently defined, this

Re: RFR:JDK-8148949:DateTimeFormatter pattern letters 'A','n','N'

Hi Nadeesh, src/java.base/share/classes/java/time/format/DateTimeFormatterBuilder:1522-1524 Is the switch from SignStyle.NOT_NEGATIVE to NORMAL intentional? The ValueRange of MilliOfDay for example is (0, 8640-1), so negative values would be out of range. Similarly, NanoOfSecond and

Re: RFR:JDK-8148949:DateTimeFormatter pattern letters 'A','n','N'

Hi all, Thanks Stephen for the comments. Please see the updated webrev http://cr.openjdk.java.net/~ntv/8148949/webrev.02/ Regards, Nadeesh On 4/28/2016 7:58 PM, Stephen Colebourne wrote: I'd like to see the test cases in test_secondsPattern() check the result of the parse (by passing more

Re: RFR:JDK-8148949:DateTimeFormatter pattern letters 'A','n','N'

I'd like to see the test cases in test_secondsPattern() check the result of the parse (by passing more arguments from data_secondsPattern) Otherwise looks good. Stephen On 28 April 2016 at 14:12, nadeesh tv wrote: > Hi all, > Please see the updated webrev >

Re: RFR:JDK-8148949:DateTimeFormatter pattern letters 'A','n','N'

Hi all, Please see the updated webrev http://cr.openjdk.java.net/~ntv/8148949/webrev.01/ Regards, Nadeesh TV On 4/25/2016 8:08 PM, nadeesh tv wrote: HI all, Please review a fix for Bug ID - https://bugs.openjdk.java.net/browse/JDK-8148949 Issue - Pattern letters 'A' does not match the

RFR:JDK-8148949:DateTimeFormatter pattern letters 'A','n','N'

HI all, Please review a fix for Bug ID - https://bugs.openjdk.java.net/browse/JDK-8148949 Issue - Pattern letters 'A' does not match the intent of LDML/CLDR Solution - Changed the definition of pattern letters 'A','n','N' Webrev - http://cr.openjdk.java.net/~ntv/8148949/webrev.00/ --