Re: RFR:JDK-8155823: Add date-time patterns 'v' and 'vvvv'

Looks fine. Thanks for the updates, Roger On 5/11/2016 4:30 AM, Stephen Colebourne wrote: This seems fine by me. Stephen On 10 May 2016 at 19:25, nadeesh tv wrote: Hi, Stephen, Roger Thanks for the comments. Please see the updated webrev

Re: RFR:JDK-8155823: Add date-time patterns 'v' and 'vvvv'

This seems fine by me. Stephen On 10 May 2016 at 19:25, nadeesh tv wrote: > Hi, > > Stephen, Roger Thanks for the comments. > Please see the updated webrev > http://cr.openjdk.java.net/~ntv/8155823/webrev.04/ > > Apart from the fix, made a correction in the java doc of

Re: RFR:JDK-8155823: Add date-time patterns 'v' and 'vvvv'

Hi, Stephen, Roger Thanks for the comments. Please see the updated webrev http://cr.openjdk.java.net/~ntv/8155823/webrev.04/ Apart from the fix, made a correction in the java doc of ZoneRules.java Thanks and Regards, Nadeesh On 5/10/2016 12:54 AM, Roger Riggs wrote: Hi Nadeesh,

Re: RFR:JDK-8155823: Add date-time patterns 'v' and 'vvvv'

Hi Nadeesh, java/time/format/DateTimeFormatter.java: line 312 - Move 'v' up 1 line so it is after 'V' and before 'z'. Also in DateTimeFormatterBuilder.java: line 1415+ - the description of the number of letters does not need to be repeated; put one copy before the specifics of 'z' and

Re: RFR:JDK-8155823: Add date-time patterns 'v' and 'vvvv'

This line: * v generic time-zone name zone-name Pacific Standard Time; PT should be * v generic time-zone name zone-name Pacific Time; PT Missing space before "false" at line 1226: appendInternal(new ZoneTextPrinterParser(textStyle,

RFR:JDK-8155823: Add date-time patterns 'v' and 'vvvv'

Hi all, Reposting because subject line did not follow the format. Bug Id : https://bugs.openjdk.java.net/browse/JDK-8155823 Issue: Add date-time patterns 'v' and '' webrev: http://cr.openjdk.java.net/~ntv/8155823/webrev.03/ This webrev also contain the fix of related bug