Re: RFR[10]:8159526 Deprivilege jdk.httpserver

2017-09-13 Thread vyom tewari
On Tuesday 12 September 2017 09:16 PM, Sean Mullan wrote: On 9/12/17 4:06 AM, vyom tewari wrote: Hi, Please review the below code change. BugId: https://bugs.openjdk.java.net/browse/JDK-8159526 Webrev-1: http://cr.openjdk.java.net/~vtewari/8159526/jdk/webrev/index.html Can you put the en

Re: RFR[10]:8159526 Deprivilege jdk.httpserver

2017-09-12 Thread mandy chung
This patch looks fine.  It's fine with me to follow up the second phase to identify the permissions needed rather than granting AllPermissions. Mandy On 9/12/17 1:06 AM, vyom tewari wrote: Hi, Please review the below code change. BugId: https://bugs.openjdk.java.net/browse/JDK-8159526 Webre

Re: RFR[10]:8159526 Deprivilege jdk.httpserver

2017-09-12 Thread Sean Mullan
On 9/12/17 4:06 AM, vyom tewari wrote: Hi, Please review the below code change. BugId: https://bugs.openjdk.java.net/browse/JDK-8159526 Webrev-1: http://cr.openjdk.java.net/~vtewari/8159526/jdk/webrev/index.html Can you put the entry for jdk.httpserver after jdk.dynalink so you maintain the

Re: RFR[10]:8159526 Deprivilege jdk.httpserver

2017-09-12 Thread Chris Hegarty
> On 12 Sep 2017, at 09:46, vyom tewari wrote: > > On Tuesday 12 September 2017 02:12 PM, Alan Bateman wrote: >> On 12/09/2017 09:06, vyom tewari wrote: >>> Hi, >>> >>> Please review the below code change. >>> >>> BugId: https://bugs.openjdk.java.net/browse/JDK-8159526 >>> >>> Webrev-1: http:

Re: RFR[10]:8159526 Deprivilege jdk.httpserver

2017-09-12 Thread Michael McMahon
Looks good Vyom. - Michael On 12/09/2017, 09:46, vyom tewari wrote: On Tuesday 12 September 2017 02:12 PM, Alan Bateman wrote: On 12/09/2017 09:06, vyom tewari wrote: Hi, Please review the below code change. BugId: https://bugs.openjdk.java.net/browse/JDK-8159526 Webrev-1: http://cr.ope

Re: RFR[10]:8159526 Deprivilege jdk.httpserver

2017-09-12 Thread vyom tewari
On Tuesday 12 September 2017 02:12 PM, Alan Bateman wrote: On 12/09/2017 09:06, vyom tewari wrote: Hi, Please review the below code change. BugId: https://bugs.openjdk.java.net/browse/JDK-8159526 Webrev-1: http://cr.openjdk.java.net/~vtewari/8159526/jdk/webrev/index.html Webrev-2: http:

Re: RFR[10]:8159526 Deprivilege jdk.httpserver

2017-09-12 Thread Alan Bateman
On 12/09/2017 09:06, vyom tewari wrote: Hi, Please review the below code change. BugId: https://bugs.openjdk.java.net/browse/JDK-8159526 Webrev-1: http://cr.openjdk.java.net/~vtewari/8159526/jdk/webrev/index.html Webrev-2: http://cr.openjdk.java.net/~vtewari/8159526/root/webrev/index.html

RFR[10]:8159526 Deprivilege jdk.httpserver

2017-09-12 Thread vyom tewari
Hi, Please review the below code change. BugId: https://bugs.openjdk.java.net/browse/JDK-8159526 Webrev-1: http://cr.openjdk.java.net/~vtewari/8159526/jdk/webrev/index.html Webrev-2: http://cr.openjdk.java.net/~vtewari/8159526/root/webrev/index.html Code change will De-privilege jdk.httpserve