Re: RFR (JAXP) 8156845: Uri is getting incorrectly unwrapped

2016-05-17 Thread Lance Andersen
Ok to push joe > On May 17, 2016, at 3:37 PM, huizhe wang wrote: > > Thanks Lance! > > On 5/17/2016 11:26 AM, Lance Andersen wrote: >> Hi Joe >> >> It looks OK. The formatting is a bit off where you encased existing code >> with new if statements so I would consider fixing that before you

Re: RFR (JAXP) 8156845: Uri is getting incorrectly unwrapped

2016-05-17 Thread huizhe wang
Thanks Lance! On 5/17/2016 11:26 AM, Lance Andersen wrote: Hi Joe It looks OK. The formatting is a bit off where you encased existing code with new if statements so I would consider fixing that before you push It seems it has something to do with whitespaces. I re-generated the webrev. A

Re: RFR (JAXP) 8156845: Uri is getting incorrectly unwrapped

2016-05-17 Thread Lance Andersen
Hi Joe It looks OK. The formatting is a bit off where you encased existing code with new if statements so I would consider fixing that before you push Best Lance > On May 17, 2016, at 12:42 PM, huizhe wang wrote: > > Hi, > > This patch fixes a missing feature in CatalogUriResolver where an

RFR (JAXP) 8156845: Uri is getting incorrectly unwrapped

2016-05-17 Thread huizhe wang
Hi, This patch fixes a missing feature in CatalogUriResolver where an uri entry can be referenced by a publicid (urn:publicid), similar to that of the public entry. The fix then is basically sharing the process for a public entry. JBS: https://bugs.openjdk.java.net/browse/JDK-8156845 webrev: