Thanks Naoto for the fast review!
Best regards,
Joe
On 12/4/18, 1:53 PM, naoto.s...@oracle.com wrote:
Hi Joe,
Those changes in the resource bundles look fine to me.
Naoto
On 12/4/18 1:45 PM, Joe Wang wrote:
Hi Naoto and all,
Could you please take a look at the changes to the resource files
Hi Joe,
Those changes in the resource bundles look fine to me.
Naoto
On 12/4/18 1:45 PM, Joe Wang wrote:
Hi Naoto and all,
Could you please take a look at the changes to the resource files for
tests of JDK-8172365 & JDK-8210408?
Current webrevs:
http://cr.openjdk.java.net/~joehw/jdk12/8213
Hi Naoto and all,
Could you please take a look at the changes to the resource files for
tests of JDK-8172365 & JDK-8210408?
Current webrevs:
http://cr.openjdk.java.net/~joehw/jdk12/8213325/webrev_v04/
Previous:
http://cr.openjdk.java.net/~joehw/jdk12/8213325/webrev_v03/
Thanks,
Joe
On 11/16
Hi Daniel,
On 11/16/18, 10:32 AM, Daniel Fuchs wrote:
Hi Joe,
1. It looks as if the parser will not complain if the root element
is seen twice - and it looks as if it is a supported feature
since the previous implementation also had a counter.
Should this be tested?
If this is a fe
Hi Joe,
1. It looks as if the parser will not complain if the root element
is seen twice - and it looks as if it is a supported feature
since the previous implementation also had a counter.
Should this be tested?
If this is a feature and multiple roots are supported
then the new i
Hi Daniel,
I deleted the endDTD method. It could have been used to signal the end
of DTD parsing and therefore serve as a validation point. However, the
parser would have thrown Exceptions if a DTD parsing wasn't completed
properly, that seems to make an endDTD check unnecessary, at least as
Hi Daniel,
You're right. It isn't strictly necessary. It was there only because it
was in a pair with startDTD as in the original SAX interface. I can
remove it as it doesn't serve anything here.
Thanks,
Joe
On 11/14/18, 2:32 AM, Daniel Fuchs wrote:
Hi Joe,
I do not see where the new DTDHa
Hi Joe,
I do not see where the new DTDHandler::endDTD methos is called.
Is that an oversight or is there more magic?
best regards,
-- daniel
On 14/11/2018 05:18, Joe Wang wrote:
Hi,
Please review a patch to bring the small footprint parser for
java.util.Properties compliant with the specifi
Hi,
Please review a patch to bring the small footprint parser for
java.util.Properties compliant with the specification.
JBS: https://bugs.openjdk.java.net/browse/JDK-8213325
webrevs: http://cr.openjdk.java.net/~joehw/jdk12/8213325/webrev/
Thanks,
Joe
