Re: RFR (JDK 13/java.xml) 8222415: Xerces 2.12.0: Parsing Configuration

2019-04-16 Thread Joe Wang
Thanks Lance! Pushed after changing 3078/79 back to 3078. Best, Joe On 4/16/19, 1:14 PM, Lance Andersen wrote: Hi Joe, Overall, I think the updates look OK. One minor correction/cleanup for before you push is in the XMLEntityManager line 3078/79 to move back the else to 3078 No need to u

Re: RFR (JDK 13/java.xml) 8222415: Xerces 2.12.0: Parsing Configuration

2019-04-16 Thread Lance Andersen
Hi Joe, Overall, I think the updates look OK. One minor correction/cleanup for before you push is in the XMLEntityManager line 3078/79 to move back the else to 3078 No need to update the webrev HTH Best Lance > On Apr 15, 2019, at 3:46 PM, Joe Wang wrote: > > Please review an update from Xe

RFR (JDK 13/java.xml) 8222415: Xerces 2.12.0: Parsing Configuration

2019-04-15 Thread Joe Wang
Please review an update from Xerces in the configuration area. The patch contains changes not easily measurable with test (e.g. a few bytes for a parse, or small leaks for a file as large as a GB, or none at all). But the change does improve in that a method ( readAndBuffer) that explicitly buf