Re: RFR (M) CR 8023234: StampedLock serializes readers on writer unlock

2013-08-26 Thread Aleksey Shipilev
Reminder :) -Aleksey. On 08/23/2013 02:38 PM, Aleksey Shipilev wrote: Hm, I think I still need the second reviewer. Anyone? http://cr.openjdk.java.net/~shade/8023234/webrev.01/ -Aleksey. On 08/21/2013 11:05 PM, Aleksey Shipilev wrote: Thanks Martin! I need a sponsor to push this.

Re: RFR (M) CR 8023234: StampedLock serializes readers on writer unlock

2013-08-26 Thread Paul Sandoz
On Aug 26, 2013, at 2:20 PM, Aleksey Shipilev aleksey.shipi...@oracle.com wrote: Reminder :) IIRC one reviewer should be sufficient, plus i don't feel qualified to review this at the moment. But i suspect you will also need a committer :-) i can do that for you. Paul.

Re: RFR (M) CR 8023234: StampedLock serializes readers on writer unlock

2013-08-26 Thread Aleksey Shipilev
On 08/26/2013 05:18 PM, Paul Sandoz wrote: On Aug 26, 2013, at 2:20 PM, Aleksey Shipilev aleksey.shipi...@oracle.com wrote: Reminder :) IIRC one reviewer should be sufficient, plus i don't feel qualified to review this at the moment. But i suspect you will also need a committer :-) i

Re: RFR (M) CR 8023234: StampedLock serializes readers on writer unlock

2013-08-26 Thread Aleksey Shipilev
On 08/26/2013 05:37 PM, Aleksey Shipilev wrote: On 08/26/2013 05:18 PM, Paul Sandoz wrote: On Aug 26, 2013, at 2:20 PM, Aleksey Shipilev aleksey.shipi...@oracle.com wrote: Reminder :) IIRC one reviewer should be sufficient, plus i don't feel qualified to review this at the moment. But i

Re: RFR (M) CR 8023234: StampedLock serializes readers on writer unlock

2013-08-23 Thread Aleksey Shipilev
Hm, I think I still need the second reviewer. Anyone? http://cr.openjdk.java.net/~shade/8023234/webrev.01/ -Aleksey. On 08/21/2013 11:05 PM, Aleksey Shipilev wrote: Thanks Martin! I need a sponsor to push this. -Aleksey. P.S. The support for multi-threaded tests in jtreg/library is

Re: RFR (M) CR 8023234: StampedLock serializes readers on writer unlock

2013-08-21 Thread Aleksey Shipilev
Thanks Martin! I need a sponsor to push this. -Aleksey. P.S. The support for multi-threaded tests in jtreg/library is one of the things I'm eager to have. On 08/21/2013 10:53 PM, Martin Buchholz wrote: OK, approved! I would do things differently, and there is the deeper problem that

Re: RFR (M) CR 8023234: StampedLock serializes readers on writer unlock

2013-08-20 Thread Aleksey Shipilev
Thanks Martin! New webrev: http://cr.openjdk.java.net/~shade/8023234/webrev.01/ On 08/20/2013 03:06 AM, Martin Buchholz wrote: Thanks. Looks good. Style suggestions for the test: +while(!isDone !isInterrupted()) { SPC after keywords. Fixed. I think it's more readable to

RFR (M) CR 8023234: StampedLock serializes readers on writer unlock

2013-08-19 Thread Aleksey Shipilev
Hi, This is the review for the issue originally found by Dr. Heinz Kabutz and Victor Grazi. The issue is consequently diagnosed and fixed by Doug Lea in JSR 166 CVS. The webrev which brings in the fix and the regression tests in JDK 8: http://cr.openjdk.java.net/~shade/8023234/webrev.00/