Re: RFR (S): 8076461: JSR292: remove unused native and constants

... thank you, Vladimir! Best, Michael > Am 14.04.2015 um 13:47 schrieb Vladimir Ivanov : > > Looks good. > > I'll push it for you. > > Best regards, > Vladimir Ivanov -- Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 3

Re: RFR (S): 8076461: JSR292: remove unused native and constants

Looks good. I'll push it for you. Best regards, Vladimir Ivanov On 4/14/15 2:33 PM, Michael Haupt wrote: Hi John, thanks again; I've applied your suggestions, re-tested as before and uploaded the revision to http://cr.openjdk.java.net/~mhaupt/8076461/webrev.02/. Best, Michael Am 13.04.20

Re: RFR (S): 8076461: JSR292: remove unused native and constants

Hi John, thanks again; I've applied your suggestions, re-tested as before and uploaded the revision to http://cr.openjdk.java.net/~mhaupt/8076461/webrev.02/. Best, Michael > Am 13.04.2015 um 21:38 schrieb John Rose : > > That's much better; thanks. Glad to hear the verifyC's still works. >

Re: RFR (S): 8076461: JSR292: remove unused native and constants

That's much better; thanks. Glad to hear the verifyC's still works. The MN_* constants are a private interface between C++ and Java code. Those are the most important to verify. You can get rid of these lines; we don't look at vtable indexes any more: // The JVM uses values of -2 and a

Re: RFR (S): 8076461: JSR292: remove unused native and constants

Hi John, thank you very much for your review; keeping the Constants class around for VM/JDK constant value agreement certainly makes sense. I have undone most of the removal work and verified in a slowdebug build that MHN.verifyConstants() works. I've also added a comment on the Constants class

Re: RFR (S): 8076461: JSR292: remove unused native and constants

On Apr 7, 2015, at 12:11 PM, Michael Haupt wrote: > > Dear all, > > please review and sponsor this change. Cross-posted to hs-comp and core-lib > as this is at the JVM/libraries boundary. This is a straightforward > refactoring change that removes many constants and unused API from MHNatives,

Re: RFR (S): 8076461: JSR292: remove unused native and constants

Hello, in case anyone was wondering about the empty changeset in the webrev: that's fixed now. Thanks to Vladimir I. for pointing out the glitch in my webrev creation approach. :-) Best, Michael > Am 07.04.2015 um 21:11 schrieb Michael Haupt : > > Dear all, > > please review and sponsor thi

RFR (S): 8076461: JSR292: remove unused native and constants

Dear all, please review and sponsor this change. Cross-posted to hs-comp and core-lib as this is at the JVM/libraries boundary. This is a straightforward refactoring change that removes many constants and unused API from MHNatives, and places some constants used only in MemberName in that class