RE: RFR (S): 8221979: Cleanups for building Windows resources

2019-04-10 Thread Langer, Christoph
; core-libs-dev > > Subject: Re: RFR (S): 8221979: Cleanups for building Windows resources > > Hello, > > Looks ok to me. > > I assume you have inspected all affected files and made sure all > attributes are the same pre and post this change? > > /Erik > >

Re: RFR (S): 8221979: Cleanups for building Windows resources

2019-04-09 Thread Erik Joelsson
Hello, Looks ok to me. I assume you have inspected all affected files and made sure all attributes are the same pre and post this change? /Erik On 2019-04-09 02:55, Langer, Christoph wrote: Hi, during work on JDK-8221880 I spotted some opportunity for cleanup in Windows resource files

RFR (S): 8221979: Cleanups for building Windows resources

2019-04-09 Thread Langer, Christoph
Hi, during work on JDK-8221880 I spotted some opportunity for cleanup in Windows resource files and their handling in the build. The naming of variables used for customizing resource properties in the build system should be aligned between hotspot and JDK. This should be carefully reviewed by