RE: RFR (S): 8235750: [jpackage] Cleanup imports in WinMsiBundler.java

2019-12-12 Thread Langer, Christoph
Thanks, Andy and Alexey for the reviews. I've pushed it. Cheers Christoph > -Original Message- > From: core-libs-dev On Behalf > Of Andy Herrick > Sent: Mittwoch, 11. Dezember 2019 15:25 > To: core-libs-dev@openjdk.java.net > Subject: Re: RFR (S): 8235750: [jpack

Re: RFR (S): 8235750: [jpackage] Cleanup imports in WinMsiBundler.java

2019-12-11 Thread Alexey Semenyuk
Looks good. - Alexey On 12/11/2019 9:25 AM, Andy Herrick wrote: looks good - thank you. /Andy On 12/11/2019 5:02 AM, Langer, Christoph wrote: Hi, please review this import statements cleanup for src/jdk.incubator.jpackage/windows/classes/jdk/incubator/jpackage/internal/WinMsiBundler.java.

Re: RFR (S): 8235750: [jpackage] Cleanup imports in WinMsiBundler.java

2019-12-11 Thread Andy Herrick
looks good - thank you. /Andy On 12/11/2019 5:02 AM, Langer, Christoph wrote: Hi, please review this import statements cleanup for src/jdk.incubator.jpackage/windows/classes/jdk/incubator/jpackage/internal/WinMsiBundler.java. I stumbled over an issue when I imported the jpackage project into

RFR (S): 8235750: [jpackage] Cleanup imports in WinMsiBundler.java

2019-12-11 Thread Langer, Christoph
Hi, please review this import statements cleanup for src/jdk.incubator.jpackage/windows/classes/jdk/incubator/jpackage/internal/WinMsiBundler.java. I stumbled over an issue when I imported the jpackage project into Eclipse. Due to importing both, static jdk.incubator.jpackage.internal.Standard