Looks good.
On Oct 2, 2013, at 12:33 PM, John Rose wrote:
> Push-button webrev generator to the rescue:
> http://cr.openjdk.java.net/~jrose/8024599/webrev.01
>
> — John
>
> On Oct 2, 2013, at 11:23 AM, Christian Thalinger
> wrote:
>
>> Since there is no new webrev I assume you incorporated
Push-button webrev generator to the rescue:
http://cr.openjdk.java.net/~jrose/8024599/webrev.01
— John
On Oct 2, 2013, at 11:23 AM, Christian Thalinger
wrote:
> Since there is no new webrev I assume you incorporated all the stuff below.
> If that's the case then it looks good.
>
> On Sep
Since there is no new webrev I assume you incorporated all the stuff below. If
that's the case then it looks good.
On Sep 20, 2013, at 6:18 PM, John Rose wrote:
> On Sep 20, 2013, at 8:29 AM, Vladimir Ivanov
> wrote:
>
>> John,
>>
>> I don't see much value in documenting buggy behavior of
On Sep 20, 2013, at 8:29 AM, Vladimir Ivanov
wrote:
> John,
>
> I don't see much value in documenting buggy behavior of early JDK7 in JDK8
> code. So, I would remove it.
OK. I think I had it in mainly to make sure the unit tests did something
interesting.
> Regarding the test:
> 31 * @ru
John,
I don't see much value in documenting buggy behavior of early JDK7 in
JDK8 code. So, I would remove it.
Regarding the test:
31 * @run main/othervm/timeout=3600
- why do you have timeout set to 1h?
I like the idea how you count events.
As a suggestion for enhancement - maybe it's m
On Sep 12, 2013, at 7:24 PM, John Rose wrote:
> Please review this change for a change to the JSR 292 implementation:
>
> http://cr.openjdk.java.net/~jrose/8024599/webrev.00/
>
> Summary: Align MH semantic with bytecode behavior of constructor and static
> member accesses, regarding invocatio
Please review this change for a change to the JSR 292 implementation:
http://cr.openjdk.java.net/~jrose/8024599/webrev.00/
Summary: Align MH semantic with bytecode behavior of constructor and static
member accesses, regarding invocation.
The change is to javadoc and unit tests, documenting and
