Re: RFR (XS): 8157188: 2 test failures in demo/jvmti due to unexpected class file version 53

2016-05-19 Thread serguei.spit...@oracle.com
David, The change looks good but you already have enough reviewers. :) Just wanted to thank you for taking steps on this issue. Thanks, Serguei On 5/18/16 21:52, David Holmes wrote: Not sure who really owns this file so cc'ing core-libs and serviceability. bug: https://bugs.openjdk.java.net

Re: RFR (XS): 8157188: 2 test failures in demo/jvmti due to unexpected class file version 53

2016-05-19 Thread David Holmes
Thanks Alan! David On 19/05/2016 3:37 PM, Alan Bateman wrote: On 19/05/2016 05:52, David Holmes wrote: Not sure who really owns this file so cc'ing core-libs and serviceability. bug: https://bugs.openjdk.java.net/browse/JDK-8157188 The file src/java.base/share/native/include/classfile_consta

Re: RFR (XS): 8157188: 2 test failures in demo/jvmti due to unexpected class file version 53

2016-05-19 Thread David Holmes
Thanks Dmitry! David On 19/05/2016 3:01 PM, Dmitry Samersoff wrote: David, Looks good for me. Probably I was the last person who do something with java_crw_demo.c. -Dmitry On 2016-05-19 07:52, David Holmes wrote: Not sure who really owns this file so cc'ing core-libs and serviceability. b

Re: RFR (XS): 8157188: 2 test failures in demo/jvmti due to unexpected class file version 53

2016-05-18 Thread Alan Bateman
On 19/05/2016 05:52, David Holmes wrote: Not sure who really owns this file so cc'ing core-libs and serviceability. bug: https://bugs.openjdk.java.net/browse/JDK-8157188 The file src/java.base/share/native/include/classfile_constants.h describes information about classfiles and is used by lib

Re: RFR (XS): 8157188: 2 test failures in demo/jvmti due to unexpected class file version 53

2016-05-18 Thread Dmitry Samersoff
David, Looks good for me. Probably I was the last person who do something with java_crw_demo.c. -Dmitry On 2016-05-19 07:52, David Holmes wrote: > Not sure who really owns this file so cc'ing core-libs and serviceability. > > bug: https://bugs.openjdk.java.net/browse/JDK-8157188 > > The file

RFR (XS): 8157188: 2 test failures in demo/jvmti due to unexpected class file version 53

2016-05-18 Thread David Holmes
Not sure who really owns this file so cc'ing core-libs and serviceability. bug: https://bugs.openjdk.java.net/browse/JDK-8157188 The file src/java.base/share/native/include/classfile_constants.h describes information about classfiles and is used by libverify and ./demo/share/jvmti/java_crw_dem