RFR (XS) CR 8004141: UnsafeStaticFieldAccessorImpl#base should be final

2012-11-29 Thread Aleksey Shipilev
Hi, Submitted the original issue found by Peter Levart [1] as CR 8004141. Peter had suggested the trivial change [2] to fix this. Please review. Thanks, Aleksey. [1] http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-November/012498.html [2] http://dl.dropbox.com/u/101777488/jdk8-hacks/U

Re: RFR (XS) CR 8004141: UnsafeStaticFieldAccessorImpl#base should be final

2012-11-29 Thread Chris Hegarty
Looks fine to me Aleksey. Let me know if you need a sponsor to get this into jdk8. -Chris. On 11/29/2012 11:05 AM, Aleksey Shipilev wrote: Hi, Submitted the original issue found by Peter Levart [1] as CR 8004141. Peter had suggested the trivial change [2] to fix this. Please review. Thanks,

Re: RFR (XS) CR 8004141: UnsafeStaticFieldAccessorImpl#base should be final

2012-11-29 Thread Aleksey Shipilev
I do, since I do not have the commit rights into OpenJDK repos. Thanks! -Aleksey. On 11/29/2012 03:19 PM, Chris Hegarty wrote: > Looks fine to me Aleksey. Let me know if you need a sponsor to get this > into jdk8. > > -Chris. > > On 11/29/2012 11:05 AM, Aleksey Shipilev wrote: >> Hi, >> >> Subm

Re: RFR (XS) CR 8004141: UnsafeStaticFieldAccessorImpl#base should be final

2012-11-29 Thread Alan Bateman
On 29/11/2012 11:05, Aleksey Shipilev wrote: Hi, Submitted the original issue found by Peter Levart [1] as CR 8004141. Peter had suggested the trivial change [2] to fix this. Please review. Thanks, Aleksey. [1] http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-November/012498.html [2]

Re: RFR (XS) CR 8004141: UnsafeStaticFieldAccessorImpl#base should be final

2012-11-29 Thread Aleksey Shipilev
On 11/29/2012 03:22 PM, Alan Bateman wrote: > It looks fine, are you looking for a sponsor? Thanks. Chris had already volunteered for this. -Aleksey.