My proposed changes are now in JSR166 CVS.
Syncing work is needed before jdk8 ships!
On Mon, Apr 29, 2013 at 6:14 PM, Mike Duigou wrote:
> Looks reasonable to me. Could BlockingDeque::push() just use {@inheritDoc}
> for main body doc?
>
>
Perhaps. But as I wrote many years ago in the same source file,
/*
* We have "diamond" multiple interface inheritance here, and that
Looks reasonable to me. Could BlockingDeque::push() just use {@inheritDoc} for
main body doc?
Mike
On Apr 29 2013, at 18:05 , Martin Buchholz wrote:
> Below is my proposed alternative fix, that also adds some missing @throws,
> reuses some existing wording, and makes small improvements to exi
Below is my proposed alternative fix, that also adds some missing @throws,
reuses some existing wording, and makes small improvements to existing
@throws specs (maintaining these specs is very tedious...)
Index: src/main/java/util/Deque.java
===
OK, I will wait on that and hopefully Chris can pick it up on the next jsr166
sync.
Mike
On Apr 29 2013, at 16:43 , Martin Buchholz wrote:
> As always for changes to files maintained in jsr166 CVS, we'd like changes to
> flow through jsr166 CVS into openjdk proper.
>
> In this case, there are
As always for changes to files maintained in jsr166 CVS, we'd like changes
to flow through jsr166 CVS into openjdk proper.
In this case, there are some issues with missing exception specs in
implementing classes. I'll come up with a diff.
Martin
On Fri, Apr 26, 2013 at 5:12 PM, Mike Duigou wr
Looks fine to me too.
-Chris.
On 27/04/2013 02:05, Mandy Chung wrote:
Looks good to me.
Mandy
On Apr 26, 2013, at 5:12 PM, Mike Duigou wrote:
Hello all;
A very small change to review.
http://cr.openjdk.java.net/~mduigou/JDK-7178639/0/webrev/
The change removes some erroneous documentati
On 27/04/2013 01:12, Mike Duigou wrote:
Hello all;
A very small change to review.
http://cr.openjdk.java.net/~mduigou/JDK-7178639/0/webrev/
The change removes some erroneous documentation from the Deque push() method.
Mike
Looks fine to me too.
-Alan
Looks good to me.
Mandy
On Apr 26, 2013, at 5:12 PM, Mike Duigou wrote:
> Hello all;
>
> A very small change to review.
>
> http://cr.openjdk.java.net/~mduigou/JDK-7178639/0/webrev/
>
> The change removes some erroneous documentation from the Deque push() method.
>
> Mike
Hello all;
A very small change to review.
http://cr.openjdk.java.net/~mduigou/JDK-7178639/0/webrev/
The change removes some erroneous documentation from the Deque push() method.
Mike
10 matches
Mail list logo
