Re: RFR [14/java.xml] 7148925: StAXSource causes exceptions to be thrown with certain wellformed XML instances

2019-07-09 Thread Joe Wang
On 7/9/19 3:07 PM, Lance Andersen wrote: Hi Joe, Overall, this looks good. Thanks Lance! Please add the bug number to the top @bug in the test class. Added. I might have defined all of the elements in the DataProvider “xml” in separate String objects to make it easier to read, but

Re: RFR [14/java.xml] 7148925: StAXSource causes exceptions to be thrown with certain wellformed XML instances

2019-07-09 Thread Lance Andersen
Hi Joe, Overall, this looks good. Please add the bug number to the top @bug in the test class. I might have defined all of the elements in the DataProvider “xml” in separate String objects to make it easier to read, but no big deal and does not need changed prior to pushing. > On Jul 9,

RFR [14/java.xml] 7148925: StAXSource causes exceptions to be thrown with certain wellformed XML instances

2019-07-09 Thread Joe Wang
Please review a fix for an Exception caused by StAXSource. The fix adds code that processes the prolog and misc content as specified by the XML specification, and removes the code that made incorrect assumption about XML document structure. https://bugs.openjdk.java.net/browse/JDK-7148925