Re: RFR [14/java.xml] 8231083: Clarify SAX documentation

Thanks Alan! Joe On 9/20/19 10:03 AM, Alan Bateman wrote: On 20/09/2019 17:46, Joe Wang wrote: Thanks Alan! Here's the updated webrev after changing the apiNote as you suggested: http://cr.openjdk.java.net/~joehw/jdk14/8231083/webrev02/index.html Looks good.

Re: RFR [14/java.xml] 8231083: Clarify SAX documentation

On 20/09/2019 17:46, Joe Wang wrote: Thanks Alan! Here's the updated webrev after changing the apiNote as you suggested: http://cr.openjdk.java.net/~joehw/jdk14/8231083/webrev02/index.html Looks good.

Re: RFR [14/java.xml] 8231083: Clarify SAX documentation

Thanks Alan! Here's the updated webrev after changing the apiNote as you suggested: http://cr.openjdk.java.net/~joehw/jdk14/8231083/webrev02/index.html -Joe On 9/20/19 9:07 AM, Alan Bateman wrote: On 20/09/2019 06:15, Joe Wang wrote: Thanks Lance! Yes, saw them typos :-)  Also removed the

Re: RFR [14/java.xml] 8231083: Clarify SAX documentation

On 20/09/2019 06:15, Joe Wang wrote: Thanks Lance! Yes, saw them typos :-)  Also removed the extra space in apiNote. Updated webrev below, with removing the text in the javadoc instead of moving to the header. http://cr.openjdk.java.net/~joehw/jdk14/8231083/webrev/index.html Just a minor

Re: RFR [14/java.xml] 8231083: Clarify SAX documentation

Thanks Lance!  It's a cleanup on top of cleanup :-) On 9/20/19 4:13 AM, Lance Andersen wrote: Round 2  even looks cleaner :-) On Sep 20, 2019, at 1:15 AM, Joe Wang > wrote: Thanks Lance! Yes, saw them typos :-)  Also removed the extra space in apiNote.

Re: RFR [14/java.xml] 8231083: Clarify SAX documentation

Round 2 even looks cleaner :-) > On Sep 20, 2019, at 1:15 AM, Joe Wang > wrote: > > Thanks Lance! > > Yes, saw them typos :-) Also removed the extra space in apiNote. > > Updated webrev below, with removing the text in the javadoc instead of moving > to the

Re: RFR [14/java.xml] 8231083: Clarify SAX documentation

Thanks Lance! Yes, saw them typos :-)  Also removed the extra space in apiNote. Updated webrev below, with removing the text in the javadoc instead of moving to the header. http://cr.openjdk.java.net/~joehw/jdk14/8231083/webrev/index.html -Joe On 9/19/19 5:18 PM, Lance Andersen wrote: Hi

Re: RFR [14/java.xml] 8231083: Clarify SAX documentation

Hi Joe, Overall this looks good and also cleans up a couple of typos :-) One nit in both package-info @apiNote, you will notice an extra space before the was which could be removed before you push Best Lance > On Sep 19, 2019, at 8:00 PM, Joe Wang wrote: > > Please review a follow-up doc

RFR [14/java.xml] 8231083: Clarify SAX documentation

Please review a follow-up doc clarification patch after 8230814 [1]. In this patch, the statement with a reference to the SAX project is moved to an apiNote in package/sub-package description to reflect the fact that it is a historical note in nature. The license related text that appears in